Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use massTag for bulk-tag-builds on koji > 1.30 #137

Open
obriencj opened this issue Aug 8, 2023 · 2 comments
Open

use massTag for bulk-tag-builds on koji > 1.30 #137

obriencj opened this issue Aug 8, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@obriencj
Copy link
Owner

obriencj commented Aug 8, 2023

A new massTag API was introduced in koji 1.30 on the hub side. This acts similarly to the tagBuildBypass call, but accepts multiple builds.

https://pagure.io/koji/issue/3307
https://pagure.io/koji/pull-request/3308#_2__37

Let's add a detect in KSD and switch to that API where applicable.

@obriencj obriencj self-assigned this Aug 8, 2023
@obriencj obriencj added the enhancement New feature or request label Aug 8, 2023
@obriencj
Copy link
Owner Author

obriencj commented Aug 8, 2023

In theory this is "nicer" to koji, consuming fewer bandwidth and memory resources.

However we must note that the massTag implementation specifies behavior identical to having force=True, notify=False and thus may not be correct to use in all cases.

@obriencj
Copy link
Owner Author

obriencj commented Aug 8, 2023

need to identify what the behavior is for per-build failures here. If it's not compatible, we may need to stick with multicall tagBuildBypass after all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant