Remove double warnings

Author: EmileTrotignon

src/lexer.mll

@@ -283,7 +283,7 @@ rule reference_paren_content input start depth_paren depth_curly buffer = parse
   | '('
     {
       buffer_add_lexeme buffer lexbuf ;
-       reference_paren_content input start (depth_paren + 1) depth_curly buffer
+      reference_paren_content input start (depth_paren + 1) depth_curly buffer
         lexbuf }
   | '{'
     {
@@ -293,33 +293,28 @@ rule reference_paren_content input start depth_paren depth_curly buffer = parse
   | ')'
     {
       buffer_add_lexeme buffer lexbuf ;
-      if depth_paren = 0 then ()
+      if depth_paren = 0 then false
       else
         ( reference_paren_content input start (depth_paren - 1) depth_curly
             buffer lexbuf ) }
   | '}'
     {
       buffer_add_lexeme buffer lexbuf ;
-      if depth_curly = 0 then
+      if depth_curly = 0 then (
         warning
           input
           ~start_offset:(Lexing.lexeme_end lexbuf)
           (Parse_error.not_allowed
             ~what:"'}' (end of reference)"
             ~in_what:(
               Printf.sprintf "'%s' (custom operator)"
-                (Buffer.sub buffer 0 ((Buffer.length buffer) - 1))))
+                (Buffer.sub buffer 0 ((Buffer.length buffer) - 1)))) ;
+        true )
       else
         ( reference_paren_content input start depth_paren (depth_curly - 1)
             buffer lexbuf ) }
   | eof
-    { warning
-        input
-        ~start_offset:(Lexing.lexeme_end lexbuf)
-        (Parse_error.not_allowed
-          ~what:(Token.describe `End)
-          ~in_what:(Token.describe (reference_token start "")))
-    }
+    { false }
   | _
     {
       buffer_add_lexeme buffer lexbuf ;
@@ -333,8 +328,11 @@ and reference_content input start buffer = parse
   | '('
     {
       buffer_add_lexeme buffer lexbuf ;
-      ((reference_paren_content input start 0 0 buffer lexbuf)) ;
-      reference_content input start buffer lexbuf
+      let ref_closed = reference_paren_content input start 0 0 buffer lexbuf in
+      if ref_closed then
+        Buffer.contents buffer
+      else
+        reference_content input start buffer lexbuf
     }
   | '"' [^ '"']* '"'
     {

test/test.ml

@@ -1699,7 +1699,6 @@ let%expect_test _ =
             (paragraph
              (((f.ml (1 0) (1 9)) (simple ((f.ml (1 2) (1 9)) "(.*{})") ())))))))
          (warnings ())) |}]
-
     let quotes_with_dash =
       test "{!\"my-name\"}";
       [%expect
@@ -1720,7 +1719,7 @@ let%expect_test _ =
                 (((f.ml (1 0) (1 6)) (simple ((f.ml (1 2) (1 6)) "\"}\"") ())))))))
             (warnings ())) |}]
 
-    let quotes_with_curly_braces =
+    let operator_unbalanced =
       test "{!(.*()}";
       [%expect
         {|
@@ -1730,9 +1729,17 @@ let%expect_test _ =
              (((f.ml (1 0) (1 8)) (simple ((f.ml (1 2) (1 8)) "(.*()}") ())))))))
          (warnings
           ( "File \"f.ml\", line 1, characters 8-8:\
-           \n'}' (end of reference) is not allowed in '(.*()' (custom operator)."
-            "File \"f.ml\", line 1, characters 8-8:\
-           \nEnd of text is not allowed in '{!...}' (cross-reference)."))) |}]
+           \n'}' (end of reference) is not allowed in '(.*()' (custom operator)."))) |}]
+    let operator_eof =
+        test "{!(.*()" ;
+        [%expect {|
+          ((output
+            (((f.ml (1 0) (1 7))
+              (paragraph
+               (((f.ml (1 0) (1 7)) (simple ((f.ml (1 2) (1 7)) "(.*()") ())))))))
+           (warnings
+            ( "File \"f.ml\", line 1, characters 7-7:\
+             \nEnd of text is not allowed in '{!...}' (cross-reference)."))) |}]
   end in
   ()