Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lower bounds #223

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fix lower bounds #223

merged 1 commit into from
Apr 17, 2024

Conversation

n-osborne
Copy link
Collaborator

No description provided.

@jmid
Copy link
Contributor

jmid commented Apr 16, 2024

A suggestion:
For qcheck we've been bitten in the past by trying to support cross-versions as it quickly becomes messy.
Scenario: "Will ortac-runtime.0.5.0 require ortac-core.0.3.0 or only ortac-core.0.2.0"?
This will largely be wasted effort trying to debug lower bound failures! 😬
A qcheck example of this happening in practice: ocaml/opam-repository#24703

For this reason, I suggest using

  "ortac-core" {= version}

etc. so that ortac-runtime.0.2.0 requires precisely ortac-core.0.2.0 (and so on)
in the interest of saving you from additional pain later 🙂

@@ -32,10 +32,8 @@ depends: [
"qcheck-core" {with-test}
"qcheck-stm" {with-test}
"qcheck-multicoretests-util" {with-test}
"ortac-core"
"ortac-core" {= "0.2.0"}
Copy link
Contributor

@jmid jmid Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both dune and opam support the version variable.
A dune example here: https://github.com/ocaml-multicore/multicoretests/blob/main/dune-project#L35
A (generated) opam example here: https://github.com/ocaml-multicore/multicoretests/blob/main/qcheck-stm.opam#L27
Using it has the advantage of not needing to go around and updating many version numbers on each release 🙂

(edit: inserted missing not 😅)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@n-osborne n-osborne added this to the 0.3 milestone Apr 16, 2024
@n-osborne n-osborne merged commit df5dee0 into ocaml-gospel:main Apr 17, 2024
3 checks passed
@n-osborne n-osborne deleted the fix-lower-bounds branch February 25, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants