-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conf-openjdk: add Ubuntu-family support #25980
Conversation
CI is failing on
Note: none of these were changed (so far) in the PR.
|
Compared to the above status
The former fails with
From https://www.freshports.org/search.php?query=openjdk it seems For the latter, I'm unsure whether conf-packages should manipulate PATH to find |
I think we should not manipulate the path, it is ok with the explicit failure message. I would remove freebsd depext and add a failure message saying to install a version of openjdk if this fails to install. |
OK, the latest 3 commit attempt to do so. |
Would it make sense to add the failure messages to the other failing platforms? Or do we think we will get those passing eventually in this PR too? Failing now on
|
The error message is actually being printed for all failing platforms, it is just a bit lost in the output.
I'm open to input as to how to highlight the message a bit more. The x86_32 failure stands a bit out because the system package install is failing there with
which seems to be a known issue caused by either
Overall, there's not much more to do opam-ci-wise, so 3e9c57b marks them as expected failures. |
There's something strange going on with x86_32
I guess this could be explained by variations in "large file system" (as linked above) between CI machines? 🤔 Also fixed the x-ci-accept-failures platform name for it. |
Modulo a lint failure this is now green and should thus be good to go. |
Looks great. The linting failure is not relevant to these changes. |
Thanks! |
No description provided.