Skip to content

Broken news links contrast too low #1244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
patricoferris opened this issue Mar 2, 2021 · 9 comments
Closed

Broken news links contrast too low #1244

patricoferris opened this issue Mar 2, 2021 · 9 comments

Comments

@patricoferris
Copy link
Contributor

On the Planet news feed page there is a list of syndications. Some of these are now broken and are presented with a strikethrough and very low contrast. The contrast is in fact too low to meet WCAG standards for accessibility in particular item 1.4.3 of the WCAG 2.1 standard. The list item in the red box is an example.

broken-link

I believe the strikethrough is sufficient enough (testing using vision deficiencies emulation using the chrome browser suggests to me this is enough).

@nayaldivya if you would like, to this might a great first issue for you to contribute too? No pressure if you don't want to this is just in relation to your comment on #1241. If you could add a message if you would like to look into this or not in the not too distant future so other people know if this issue is open or not that would be fantastic. Thank you for wanting to contribute to the site :))

(If you do take this up feel free to ask any questions here on this issue or on a PR that you open in relation to it).

@nayaldivya
Copy link

Thanks @patricoferris. I would love to work on this.

@IIITM-Jay
Copy link
Contributor

IIITM-Jay commented Mar 3, 2021

@nayaldivya Are you still working on this...

@patricoferris This is Jay here, may I request any other issue on which I can work on... (or I can submit a PR on this issue)

@nayaldivya
Copy link

nayaldivya commented Mar 3, 2021

@nayaldivya Are you still working on this...
Yes.

@patricoferris
Copy link
Contributor Author

@IIITM-Jay please don't submit a PR for this issue. I have just created #1245 which, going forward, will be the place to register interest. I know you are interested and in due course I will find/create an issue and ping you about it.

@nayaldivya please don't feel any pressure to rush your contribution, take as much time as you need and don't hesitate to ask any questions on here.

@nayaldivya
Copy link

nayaldivya commented Mar 3, 2021

Hey @patricoferris, while setting up the project on my system, I ran into this error. I'm using Windows 10 as my Operating System. Kindly have a look at this.
ocaml_error

This is after I ran opam install ocamlorg --deps-only command.

@nayaldivya
Copy link

nayaldivya commented Mar 3, 2021

To resolve this issue #1244, I believe
In ocamlorg.css
.subscribers .broken { color: #dcc8c4; text-decoration: line-through; }
should be updated to
.subscribers .broken { text-decoration: line-through; }

This will change

syndications_before
to
syndications_after

Kindly confirm this.

@patricoferris
Copy link
Contributor Author

Great @nayaldivya -- that looks about right to me.

However, I would really love for you to get this up and running locally especially because you are developing on windows and any problems and solutions you find, we can add to the contributing document to help other windows devs.

I most confess windows support for OCaml isn't as good as other OSes but it looks like you have the harder bits already sorted. To start can I ask which instructions you followed to get your windows environment set up ?

@nayaldivya
Copy link

nayaldivya commented Mar 6, 2021

I followed this link: http://fdopen.github.io/opam-repository-mingw/installation/ After running the graphical installation file, it automatically installed OCaml, OPam, and Cygwin on the system.

avsm added a commit that referenced this issue Mar 9, 2021
Fixes contrast of broken news links #1244
@patricoferris
Copy link
Contributor Author

This was fixed in #1252, thanks @nayaldivya :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants