Skip to content

Resize icons in Community #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pitag-ha opened this issue Mar 30, 2021 · 9 comments
Closed

Resize icons in Community #1317

pitag-ha opened this issue Mar 30, 2021 · 9 comments

Comments

@pitag-ha
Copy link
Member

At the bottom of Community we have the OCaml around the World section. The icons there are all sized differently. Furthermore, all items but one are in the first line and the only icon in the second line is bigger than the others:

Screenshot from 2021-03-30 11-19-21

I suggest to resize the icons. For example (but could also be done differently) as follows:

  • put the same number of icons into the first line as into the second line
  • and/or: give them all the same size; make sure that more than one icon is in the second line
@TildaDares
Copy link
Contributor

This looks interesting. Can I work on this?

@pitag-ha
Copy link
Member Author

@TildaDares , sure, go ahead :)

@pitag-ha
Copy link
Member Author

Notice that I've just opened another issue that is related to this one: #1318. I'm just mentioning that so that you can take into account that there will be one more icon soon.

@TildaDares
Copy link
Contributor

Notice that I've just opened another issue that is related to this one: #1318. I'm just mentioning that so that you can take into account that there will be one more icon soon.

Noted.

@TildaDares
Copy link
Contributor

@pitag-ha How does this look?

image

@pitag-ha
Copy link
Member Author

@TildaDares , I'm no design expert, but to me that looks great, thanks! Don't hesitate to open a PR for it when you've implemented it and feel comfortable. That way we can have a look at the code.

@nibble0101
Copy link
Contributor

@pitag-ha Isn't this issue a duplicate of #1270? Looks like someone is already working on it.

@pitag-ha
Copy link
Member Author

@nibble0101 , thanks a lot for noting that! @TildaDares , I'm very sorry I missed #1270. Do you think you could find another issue you're interested in?

@pitag-ha
Copy link
Member Author

@TildaDares, would you be interested in #1320? Sorry again for the duplicate. I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants