Skip to content

extra spacing under news section on tablet view (screen size < 978 ) #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bhavika-Gianey opened this issue Apr 3, 2021 · 6 comments
Open

Comments

@Bhavika-Gianey
Copy link
Contributor

There is extra spacing under the news section of the Home page on tablet view i.e. screen size less than 978 px

On large view

old3-2

On medium view

old3-1

I would like to fix the spacing problem here.

@pitag-ha
Copy link
Member

pitag-ha commented Apr 6, 2021

What do you have in mind to improve this? :)

@Bhavika-Gianey
Copy link
Contributor Author

We can increase the padding of each list item in the news section so that it covers the unused space.

Eg:

ocaml org_ (2)

@pitag-ha
Copy link
Member

pitag-ha commented Apr 8, 2021

Yes, that would work :) There is a PR open at the moment changing that layout though. So we should wait to avoid stepping on each other's toes.

And thanks for your contributions so far, @Bhavika-Gianey , they've been great! Now, it's time for you to move forward to a harder issue. See here and here. I think this issue can be considered simple.

@Bhavika-Gianey
Copy link
Contributor Author

Yes, that would work :) There is a PR open at the moment changing that layout though. So we should wait to avoid stepping on each other's toes.

Sure @pitag-ha, actually I opened the issue earlier than the specified one so was I was confused whether to carry this issue forward or not. Shall I close it now??

@Bhavika-Gianey
Copy link
Contributor Author

And thanks for your contributions so far, @Bhavika-Gianey, they've been great! Now, it's time for you to move forward to a harder issue. See here and here. I think this issue can be considered simple.

Thanks, @pitag-ha :). I would love to learn and work on harder issues. I have seen all the medium issues are already assigned so if you come across any new issues, kindly let me know :).

@pitag-ha
Copy link
Member

pitag-ha commented Apr 9, 2021

actually I opened the issue earlier than the specified one so was I was confused whether to carry this issue forward or not.

yes, you're totally right! I'm also not sure if @guptadiksha307's PR will be merged. That's a general risk and even higher when opening PRs before discussing the idea as done in that PR.

If you want, you can also open a PR for your idea. In projects that lots of people are working on, it sometimes happens that two PR's aren't compatible and max one of them will be merged. So I'd say it's up to you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants