-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branding error and long idcs link instead of company name #36
Comments
Hi ervreugdenhil, you should be able to add the company name using the Console. Have you tried (and retried) it for the Default identity domain? |
Hi @andrecorreaneto , yes for any console create domain it works fine. I can go into the branding menu, custom branding and modify the company name without any issues. For any domain created using the CIS module, when you press save on the branding menu, there is a technical error: "An error occurred saving the settings. Cannot read properties of undefined (reading 'push')". |
Hi @andrecorreaneto, Looks like it may be related to the parameter allow_signing_cert_public_access.
I see that I originally logged this issue with the parameter value to false. I assume I must have used true to create it and then changed afterwards to false. I tested this and indeed the missing company names or the images are not put back once gone. Once the company name is missing, there are problems with certain console screens and you get weird company names in the mobile authenticator. I do notice that in the CIS modole, when you select allow_signing_cert_public_access = true, logic is triggered that handles all kinds of domain settings. Kind Regards, |
Hi!
I am using the module to create our own Identity Domain and this works great.
However, we do run into two issues:
This behaviour is not with console created identity domains. When I compare console created versus terraform created (using oci cli command "oci identity-domains branding-settings list --endpoint " I notice that for console the "company-names" is filled in (based on tenant name), while for terraform it is null (I assume this is the undefined property mentioned in the error message).
I use the module with the following attributes:
Is there a solution for this?
Is there a workaround?
Many thanks for your help!
The text was updated successfully, but these errors were encountered: