Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branding error and long idcs link instead of company name #36

Open
ervreugdenhil opened this issue Jan 29, 2025 · 3 comments
Open

Branding error and long idcs link instead of company name #36

ervreugdenhil opened this issue Jan 29, 2025 · 3 comments

Comments

@ervreugdenhil
Copy link

Hi!
I am using the module to create our own Identity Domain and this works great.
However, we do run into two issues:

  • Instead of the company name a very long IDCS link shows up in Oracle's mobile Authenticator. This can be modified manually, but this would mean that all users that we add would need to do this manually. Normally in the app the company name is defaulted based on the tenant name.
  • When I go to the console to modify branding, this is not possible. The company name is missing, and when I fill this in (and also default the pictures/logos) and save, after some time I get the error "An error occurred saving the settings. Cannot read properties of undefined (reading 'push')". Due to this error the company name cannot be filled in afterwards and also no branding can be done.

This behaviour is not with console created identity domains. When I compare console created versus terraform created (using oci cli command "oci identity-domains branding-settings list --endpoint " I notice that for console the "company-names" is filled in (based on tenant name), while for terraform it is null (I assume this is the undefined property mentioned in the error message).

I use the module with the following attributes:

    "identity_domains_configuration": {
        "identity_domains" : {  
            "<MY-KEY>"  : { 
                "display_name":     "<domain_name>",
                "description":      "<description>",
                "home_region":      <region>",
                "license_type":     "premium",
                "admin_email":      "<mail>",
                "admin_first_name": "<name>",
                "admin_last_name":  "<name>",
                "admin_user_name":  "<mail>",
                "is_hidden_on_login":           false,
                "is_notification_bypassed":     false,
                "is_primary_email_required":    true,
                "allow_signing_cert_public_access": false,
                "replica_region":   "<region>"
            }
        }
    },

Is there a solution for this?
Is there a workaround?

Many thanks for your help!

@andrecorreaneto
Copy link
Member

Hi ervreugdenhil, you should be able to add the company name using the Console. Have you tried (and retried) it for the Default identity domain?

@ervreugdenhil
Copy link
Author

Hi @andrecorreaneto , yes for any console create domain it works fine. I can go into the branding menu, custom branding and modify the company name without any issues.

For any domain created using the CIS module, when you press save on the branding menu, there is a technical error: "An error occurred saving the settings. Cannot read properties of undefined (reading 'push')".

@ervreugdenhil
Copy link
Author

ervreugdenhil commented Feb 21, 2025

Hi @andrecorreaneto,

Looks like it may be related to the parameter allow_signing_cert_public_access.

  • When I create a domain with this parameter to true, and go to branding, the company name and the images are missing (i.e. the issue occurs).
  • When I create a domain with this parameter to false, and go to branding, the company name and the images are not missing (i.e. everything works fine).

I see that I originally logged this issue with the parameter value to false. I assume I must have used true to create it and then changed afterwards to false. I tested this and indeed the missing company names or the images are not put back once gone.

Once the company name is missing, there are problems with certain console screens and you get weird company names in the mobile authenticator.

I do notice that in the CIS modole, when you select allow_signing_cert_public_access = true, logic is triggered that handles all kinds of domain settings.

Kind Regards,
Edwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants