refactor: use Array#includes instead of indexOf (#548)

wolfy1339 · web-flow · commit 9d85f761ebdc · 2021-05-28T21:25:13.000Z
diff --git a/src/event-handler/on.ts b/src/event-handler/on.ts
@@ -40,7 +40,7 @@ export function receiverOn(
     throw new Error(message);
   }
 
-  if (emitterEventNames.indexOf(webhookNameOrNames) === -1) {
+  if (!emitterEventNames.includes(webhookNameOrNames)) {
     state.log.warn(
       `"${webhookNameOrNames}" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)`
     );

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ export function receiverOn(`
`40`	`40`	`throw new Error(message);`
`41`	`41`	`}`
`42`	`42`
`43`		`- if (emitterEventNames.indexOf(webhookNameOrNames) === -1) {`
	`43`	`+ if (!emitterEventNames.includes(webhookNameOrNames)) {`
`44`	`44`	`state.log.warn(`
`45`	`45`	`"${webhookNameOrNames}" is not a known webhook name (https://developer.github.com/v3/activity/events/types/)`
`46`	`46`	`);`