Fixed support for mssql limit/offset

Author: iteufel

lib/dialects/mssql/index.js

@@ -3,9 +3,66 @@
 var BaseDialect = require('../base');
 var _ = require('underscore');
 var util = require('util');
+var templateChecks = require('../../utils/templateChecks');
 
 var Dialect = module.exports = function(builder) {
 	BaseDialect.call(this, builder);
+
+  this.blocks.set('limit', function(params) {
+		return (params.offset) ? '' : 'TOP(' + builder._pushValue(params.limit) + ')';
+	});
+
+  this.blocks.set('offset', function(params) {
+    var pre = (!params.sort) ? 'ORDER BY 1 ' : '';
+    if (params.limit) {
+      return pre + 'OFFSET ' + params.offset + ' ROWS FETCH NEXT ' + params.limit + ' ROWS ONLY';
+    }else {
+      return pre + 'OFFSET ' + params.offset + ' ROWS';
+    }
+	});
+
+  this.templates.set('select', {
+		pattern: '{with} {withRecursive} select {limit} {distinct} {fields} ' +
+			'from {from} {table} {query} {select} {expression} {alias} ' +
+			'{join} {condition} {group} {having} {sort} {offset}',
+		defaults: {
+			fields: {}
+		},
+		validate: function(type, params) {
+			templateChecks.onlyOneOfProps(type, params, ['with', 'withRecursive']);
+			templateChecks.propType(type, params, 'with', 'object');
+			templateChecks.propType(type, params, 'withRecursive', 'object');
+
+			templateChecks.propType(type, params, 'distinct', 'boolean');
+
+			templateChecks.propType(type, params, 'fields', ['array', 'object']);
+
+			templateChecks.propType(type, params, 'from', ['string', 'array', 'object']);
+
+			templateChecks.atLeastOneOfProps(type, params, ['table', 'query', 'select', 'expression']);
+			templateChecks.onlyOneOfProps(type, params, ['table', 'query', 'select', 'expression']);
+
+			templateChecks.propType(type, params, 'table', 'string');
+			templateChecks.propType(type, params, 'query', 'object');
+			templateChecks.propType(type, params, 'select', 'object');
+			templateChecks.propType(type, params, 'expression', ['string', 'object']);
+
+			templateChecks.propType(type, params, 'alias', ['string', 'object']);
+
+			templateChecks.propType(type, params, 'join', ['array', 'object']);
+
+			templateChecks.propType(type, params, 'condition', ['array', 'object']);
+			templateChecks.propType(type, params, 'having', ['array', 'object']);
+
+			templateChecks.propType(type, params, 'group', ['string', 'array']);
+
+			templateChecks.propType(type, params, 'sort', ['string', 'array', 'object']);
+
+      templateChecks.propType(type, params, 'offset', ['number', 'string']);
+			templateChecks.propType(type, params, 'limit', ['number', 'string']);
+		}
+	});
+
 };
 
 util.inherits(Dialect, BaseDialect);

package.json

@@ -18,7 +18,7 @@
     "database"
   ],
   "dependencies": {
-    "underscore": "1.8.2"
+    "underscore": "1.8.3"
   },
   "devDependencies": {
     "chai": "2.2.0",