RTF Writer Support ListItem Font Styles

ListItem stores its font style with its text in a TextObject. Use that when writing out its text. @rasamassen, you will want to add this change to one of your PRs, probably PR PHPOffice#2019.

Author: oleibman

README.md

@@ -54,7 +54,6 @@ PHPWord requires the following:
 
 - PHP 7.1+
 - [XML Parser extension](http://www.php.net/manual/en/xml.installation.php)
-- [Laminas Escaper component](https://docs.laminas.dev/laminas-escaper/intro/)
 - [Zip extension](http://php.net/manual/en/book.zip.php) (optional, used to write OOXML and ODF)
 - [GD extension](http://php.net/manual/en/book.image.php) (optional, used to add images)
 - [XMLWriter extension](http://php.net/manual/en/book.xmlwriter.php) (optional, used to write OOXML and ODF)
@@ -129,7 +128,7 @@ $fontStyle = new \PhpOffice\PhpWord\Style\Font();
 $fontStyle->setBold(true);
 $fontStyle->setName('Tahoma');
 $fontStyle->setSize(13);
-$myTextElement = $section->addText('"Believe you can and you\'re halfway there." (Theodor Roosevelt)');
+$myTextElement = $section->addText('"Believe you can and you\'re halfway there." (Theodore Roosevelt)');
 $myTextElement->setFontStyle($fontStyle);
 
 // Saving the document as OOXML file...

docs/usage/template.md

@@ -166,7 +166,7 @@ Customer: ${customer_name#3}
 Address: ${customer_address#3}
 ```
 
-It is also possible to pass an array with the values to replace the marcros with.
+It is also possible to pass an array with the values to replace the macros with.
 If an array with replacements is passed, the ``count`` argument is ignored, it is the size of the array that counts.
 
 ``` php

src/PhpWord/Writer/RTF/Element/ListItem.php

@@ -19,6 +19,7 @@
 namespace PhpOffice\PhpWord\Writer\RTF\Element;
 
 use PhpOffice\PhpWord\Element\ListItem as Li;
+use PhpOffice\PhpWord\Style;
 
 /**
  * ListItem element RTF writer; extends from text.
@@ -51,7 +52,7 @@ private function writeElement(Li $element)
         // Bullet List
         $content = '';
         $content .= $this->writeOpening();
-        if ($style instanceof \PhpOffice\PhpWord\Style\ListItem) {
+        if ($style instanceof Style\ListItem) {
             $numStyle = $style->getNumbering();
             if ($numStyle->getType() == 'singleLevel') {
                 $depth = 0;
@@ -64,13 +65,34 @@ private function writeElement(Li $element)
             $content .= '\li' . $levels[$depth]->getLeft();
             $content .= '\lin' . $levels[$depth]->getLeft();
         }
-        $content .= $this->writeFontStyle(); // Doesn't work. Don't know why. Probably something to do with \PhpOffice\PhpWord\Element\ListItem storing styles in a textObject type \PhpOffice\PhpWord\Element\Text rather than within the Element itself
+        $content .= $this->writeFontStyle(); // ListItem Text has its own font style applied later.
         $content .= PHP_EOL;
         /* $content .= '{\listtext\f2 \\\'b7\tab }'; // Not sure if needed for listItemRun
         $content .= PHP_EOL; */
         $content .= '{';
-        $content .= $this->writeText($element->getText());
+
+        $textStart = $textStyle = $textEnd = '';
+        $textFontStyle = null;
+        $textObject = $element->getTextObject();
+        if ($textObject !== null) {
+            $textFontStyle = $textObject->getFontStyle();
+            if (is_string($textFontStyle)) {
+                $textFontStyle = Style::getStyle($textFontStyle);
+            }
+        }
+        if ($textFontStyle instanceof Style\Font) {
+            $this->fontStyle = $textFontStyle;
+            $textStyle = $this->writeFontStyle();
+            if ($textStyle !== '') {
+                $textStart = '{';
+                $textEnd = '}';
+            }
+        }
+
+        $content .= $textStart . $textStyle . $this->writeText($element->getText()) . $textEnd;
+
         $content .= '}';
+
         $content .= PHP_EOL;
         $content .= $this->writeClosing();
 

src/PhpWord/Writer/RTF/Element/Ruby.php

@@ -18,6 +18,8 @@
 
 namespace PhpOffice\PhpWord\Writer\RTF\Element;
 
+use PhpOffice\PhpWord\Element\Ruby as RubyElement;
+
 /**
  * Ruby element RTF writer. Writes {baseText} ({rubyText}) in current paragraph style
  * because RTF does not natively support ruby text.
@@ -31,13 +33,16 @@ class Ruby extends AbstractElement
      */
     public function write()
     {
-        /** @var \PhpOffice\PhpWord\Element\Ruby $element */
         $element = $this->element;
-        $elementClass = str_replace('\\Writer\\RTF', '', static::class);
-        if (!$element instanceof $elementClass || !is_string($element->getBaseTextRun()->getText())) {
-            return '';
-        }
 
+        return ($element instanceof RubyElement) ? $this->writeElement($element) : '';
+    }
+
+    /**
+     * @return string
+     */
+    private function writeElement(RubyElement $element)
+    {
         $this->getStyles();
 
         $content = '';