Less Mockery

Author: oleibman

tests/PhpWordTests/Writer/EPub3/ElementTest.php renamed to tests/PhpWordTests/Writer/EPub3/Element/ElementTest.php

@@ -1,10 +1,11 @@
 <?php
 
-namespace PhpOffice\PhpWordTests\Writer\EPub3;
+namespace PhpOffice\PhpWordTests\Writer\EPub3\Element;
 
-use PhpOffice\PhpWord\Element\AbstractElement;
 use PhpOffice\PhpWord\Element\Text;
+use PhpOffice\PhpWord\Exception\Exception as WordException;
 use PhpOffice\PhpWord\Writer\EPub3\Element\AbstractElement as WriterElement;
+use PhpOffice\PhpWord\Writer\EPub3\Element\Text as TextWriter;
 use PHPUnit\Framework\TestCase;
 
 class ElementTest extends TestCase
@@ -13,14 +14,15 @@ public function testGetElementClass(): void
     {
         $element = new Text('test');
         $class = WriterElement::getElementClass($element);
-        self::assertEquals('PhpOffice\\PhpWord\\Writer\\EPub3\\Element\\Text', $class);
+        self::assertSame(TextWriter::class, $class);
     }
 
     public function testGetElementClassWithInvalidElement(): void
     {
-        $this->expectException(\PhpOffice\PhpWord\Exception\Exception::class);
+        $this->expectException(WordException::class);
+        $this->expectExceptionMessage('Writer element class');
 
-        $element = $this->createMock(AbstractElement::class);
+        $element = new FakeElement();
         WriterElement::getElementClass($element);
     }
 }

tests/PhpWordTests/Writer/EPub3/Element/FakeElement.php

@@ -0,0 +1,9 @@
+<?php
+
+namespace PhpOffice\PhpWordTests\Writer\EPub3\Element;
+
+use PhpOffice\PhpWord\Element\AbstractElement;
+
+class FakeElement extends AbstractElement
+{
+}

tests/PhpWordTests/Writer/EPub3/Element/ImageTest.php

@@ -42,7 +42,7 @@ public function testWriteWithoutP(): void
     public function testWriteWithInvalidElement(): void
     {
         $xmlWriter = new XMLWriter();
-        $invalidElement = $this->createMock(\PhpOffice\PhpWord\Element\AbstractElement::class);
+        $invalidElement = new FakeElement();
         $writer = new ImageWriter($xmlWriter, $invalidElement);
 
         $writer->write();

tests/PhpWordTests/Writer/EPub3/Element/TextTest.php

@@ -9,75 +9,63 @@
 
 class TextTest extends TestCase
 {
-    /**
-     * @var XMLWriter
-     */
-    private $xmlWriter;
-
-    /**
-     * @var Text
-     */
-    private $element;
-
-    /**
-     * @var TextWriter
-     */
-    private $writer;
-
-    protected function setUp(): void
-    {
-        $this->xmlWriter = new XMLWriter();
-        $this->element = new Text('Sample Text');
-        $this->writer = new TextWriter($this->xmlWriter, $this->element);
-    }
-
     public function testWrite(): void
     {
-        $this->writer->write();
+        $xmlWriter = new XMLWriter();
+        $element = new Text('Sample Text');
+        $writer = new TextWriter($xmlWriter, $element);
+        $writer->write();
 
         $expected = "<p>\n  <span>Sample Text</span>\n</p>\n";
-        self::assertEquals($expected, $this->xmlWriter->getData());
+        self::assertSame($expected, $xmlWriter->getData());
     }
 
     public function testWriteWithFontStyle(): void
     {
-        $this->element->setFontStyle('customStyle');
+        $xmlWriter = new XMLWriter();
+        $element = new Text('Sample Text');
+        $writer = new TextWriter($xmlWriter, $element);
+        $element->setFontStyle('customStyle');
 
-        $this->writer->write();
+        $writer->write();
 
         $expected = "<p>\n  <span class=\"customStyle\">Sample Text</span>\n</p>\n";
-        self::assertEquals($expected, $this->xmlWriter->getData());
+        self::assertSame($expected, $xmlWriter->getData());
     }
 
     public function testWriteWithParagraphStyle(): void
     {
-        $this->element->setParagraphStyle('paragraphStyle');
+        $xmlWriter = new XMLWriter();
+        $element = new Text('Sample Text');
+        $writer = new TextWriter($xmlWriter, $element);
+        $element->setParagraphStyle('paragraphStyle');
 
-        $this->writer->write();
+        $writer->write();
 
         $expected = "<p class=\"paragraphStyle\">\n  <span>Sample Text</span>\n</p>\n";
-        self::assertEquals($expected, $this->xmlWriter->getData());
+        self::assertSame($expected, $xmlWriter->getData());
     }
 
     public function testWriteWithoutP(): void
     {
         $text = new Text('Sample Text');
         $xmlWriter = new XMLWriter();
-        $this->writer = new TextWriter($xmlWriter, $text, true);
+        $writer = new TextWriter($xmlWriter, $text, true);
 
-        $this->writer->write();
+        $writer->write();
 
         $expected = "<span>Sample Text</span>\n";
-        self::assertEquals($expected, $xmlWriter->getData());
+        self::assertSame($expected, $xmlWriter->getData());
     }
 
     public function testWriteWithInvalidElement(): void
     {
-        $invalidElement = $this->createMock(\PhpOffice\PhpWord\Element\AbstractElement::class);
-        $writer = new TextWriter($this->xmlWriter, $invalidElement);
+        $xmlWriter = new XMLWriter();
+        $invalidElement = new FakeElement();
+        $writer = new TextWriter($xmlWriter, $invalidElement);
 
         $writer->write();
 
-        self::assertEquals('', $this->xmlWriter->getData());
+        self::assertSame('', $xmlWriter->getData());
     }
 }