Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the toggle icon if the _children is empty #4685

Open
nghuuphuoc opened this issue Feb 6, 2025 · 0 comments
Open

Hide the toggle icon if the _children is empty #4685

nghuuphuoc opened this issue Feb 6, 2025 · 0 comments
Labels
Suggested Feature A suggested feature that is waiting review

Comments

@nghuuphuoc
Copy link

Is your feature request related to a problem? Please describe.*

When using the DataTree module, the toggle icon is always shown even the _children is empty.
Here is the jsfiddle:

var tableDataNested = [
    ...
    {name:"James Newman", ..., _children: []},
];

As you see, the last row children is empty, but in reality, it still shows the toggle icon

Image

Describe the solution you'd like

I want the icon to be hidden if the children is empty.

I guess we need to modify the generateControlElement() function to something like this

// DataTree.js

generateControlElement(row, el){
  if(config.children !== false && config.children?.length > 0) { ... }
}
@nghuuphuoc nghuuphuoc added the Suggested Feature A suggested feature that is waiting review label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Suggested Feature A suggested feature that is waiting review
Projects
None yet
Development

No branches or pull requests

1 participant