Example of includes bug

Author: Marco Herrera-Rendon

tests/Jsona.test.ts

@@ -20,6 +20,9 @@ import {
     resourceIdObjMetaMock,
     differentAttrsInDataAndIncludedMock,
     circularWithMeta,
+    userWithIdlessSpecialties,
+    idlessSpecialty1,
+    idlessSpecialty2,
 } from './mocks';
 
 chai.config.showDiff = true;
@@ -51,6 +54,11 @@ describe('Jsona', () => {
             expect(jsonBody.included).to.be.deep.equal([specialty1.json, specialty2.json, town2.json, country2.json]);
         });
 
+        it('should build json with collection, with included resources that do not have ids', () => {
+            const jsonBody = jsona.serialize({stuff: userWithIdlessSpecialties.model, includeNames: ['specialty']});
+            expect(jsonBody.included).to.be.deep.equal([idlessSpecialty1.json, idlessSpecialty2.json]);
+        });
+
         it('should build json and save null relationships', () => {
             const jsonBody = jsona.serialize({stuff: withNullRelationsMock.collection});
             expect(jsonBody.data).to.be.deep.equal(withNullRelationsMock.json);

tests/mocks.ts

@@ -110,6 +110,32 @@ export const specialty2 = {
     }
 };
 
+export const idlessSpecialty1 = {
+    model: {
+        type: 'specialty',
+        title: 'mycategory1'
+    },
+    json: {
+        type: 'specialty',
+        attributes: {
+            title: 'mycategory1'
+        }
+    }
+};
+
+export const idlessSpecialty2 = {
+    model: {
+        type: 'specialty',
+        title: 'mycategory2'
+    },
+    json: {
+        type: 'specialty',
+        attributes: {
+            title: 'mycategory2'
+        }
+    }
+};
+
 export const user1 = {
     model: {
         type: 'user',
@@ -212,6 +238,17 @@ export const user2 = {
     }
 };
 
+export const userWithIdlessSpecialties = {
+    model: {
+        type: 'user',
+        id: '2',
+        name: 'myName2',
+        active: true,
+        specialty: [idlessSpecialty1.model, idlessSpecialty2.model],
+        [RELATIONSHIP_NAMES_PROP]: ['specialty']
+    },
+};
+
 export const article1 = {
     model: {
         type: 'article',