Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block types are not checked again when decay "realizes" #24

Open
skerit opened this issue Oct 3, 2022 · 0 comments
Open

Block types are not checked again when decay "realizes" #24

skerit opened this issue Oct 3, 2022 · 0 comments

Comments

@skerit
Copy link

skerit commented Oct 3, 2022

Players on my server were reporting issues where certain blocks in their tree farms would "pop off", things like observers & pistons.
Turns out it's because the leaf decay logic queues the removal as soon as a leaf block loses contact to a log.

Once it's in this queue, it never gets checked again. Before the queue actually gets processed, a lot can happen:

  • The leaf blocks could have already been removed & replaced with something else
  • The leaf blocks could be connected to a log again

In my fork I just made the code check the state of the block again before actually removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant