Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MB configuration "Direct links" doesn't work well with URIs #52

Open
allanaaa opened this issue Mar 8, 2023 · 2 comments
Open

MB configuration "Direct links" doesn't work well with URIs #52

allanaaa opened this issue Mar 8, 2023 · 2 comments

Comments

@allanaaa
Copy link

allanaaa commented Mar 8, 2023

URI values, that are already links, will ignore the "Direct Links" setting in MB and display a "See all items with this value" link anyways. Do we have a better way to do this?

metadatabrowse

Maybe those little external-link icons () would be helpful on our URIs. The icon can link to the external URL and the actual displaying text (whether a label or the URI itself) could be the metadata-browse link, maybe?

They are also appearing above the values they refer to, rather than below or to the right, which is confusing, so if we don't have a better answer changing that would be a good start.

With URI Dereferencer on they look extra weird.
metadatabrowse-uri2

@allanaaa
Copy link
Author

allanaaa commented Mar 8, 2023

Correction, URIs and Omeka resources (of course).

metadatabrowse2

zerocrates added a commit that referenced this issue Mar 17, 2023
Old behavior meant that Direct Links set to off had the link in a
different location, but reliably after the value. With Direct Links on,
the link wrapped literals as intended, but values that are already links
got an "indirect" link, except much closer in the markup to the actual
value, and in fact actually appearing before it.

The resolution here is: whenever making an "indirect" link, it's now in
the same place: immediately after the value content itself. This means
that the links generated with Direct Links off will move somewhat from
where they were before.

There's some small accompanying styling to account for this change:
instead of trying to force itself onto a separate line, the link is
styled to just put a small margin between itself and the value.

(#52)
@zerocrates
Copy link
Contributor

A fix for the buggy aspects of this is in, though not anything relating to changing to an icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants