Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new createvalidator in CLI #3047

Closed
fabtreb opened this issue Feb 12, 2025 · 0 comments · Fixed by #3085
Closed

Implement new createvalidator in CLI #3047

fabtreb opened this issue Feb 12, 2025 · 0 comments · Fixed by #3085
Assignees
@powerslider
Labels
sprint: ad hoc PRs or issues included mid-sprint
Milestone
c1 - Permissionle...

Comments

@fabtreb
Copy link
Contributor

fabtreb commented Feb 12, 2025 •
edited by corverroos
Loading

Problem to solve

The CreateValidator function on Staking.sol has been updated to accept a signature. The omni CLI however stil uses the old CreateValidator0 function.

Proposed solution

Switch the CLI to use the new function by creating the signature the first.
@fabtreb fabtreb added the sprint: ad hoc PRs or issues included mid-sprint label Feb 12, 2025
@powerslider powerslider mentioned this issue Feb 17, 2025
Merged
@powerslider powerslider linked a pull request Feb 17, 2025 that will close this issue
chore(cli/cmd): add sig verify to createValidator #3085
Merged
powerslider added a commit that referenced this issue Feb 17, 2025
@powerslider
chore(cli/cmd): add sig verify to createValidator (#3085)
9cda789 
call createValidator function from Staking.sol that accepts a signature
as a parameter

issue: #3047
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@powerslider powerslider

Labels
sprint: ad hoc PRs or issues included mid-sprint
Projects
None yet
Milestone
c1 - Permissionless Staking [Q1 2025]
Development

Successfully merging a pull request may close this issue.

chore(cli/cmd): add sig verify to createValidator omni-network/omni
3 participants
@powerslider @kevinhalliday @fabtreb