Merge pull request #95 from appropriate/register-subclasses

Register subclasses with OmniAuth.strategies

Author: bufferoverflow

.travis.yml

@@ -24,5 +24,8 @@ matrix:
       gemfile: Gemfile
     - rvm: ruby-head
       gemfile: Gemfile
+  allow_failures:
+    - rvm: jruby-head
+    - rvm: ruby-head
   fast_finish: true
 sudo: false

lib/omniauth/strategies/saml.rb

@@ -6,6 +6,10 @@ module Strategies
     class SAML
       include OmniAuth::Strategy
 
+      def self.inherited(subclass)
+        OmniAuth::Strategy.included(subclass)
+      end
+
       OTHER_REQUEST_OPTIONS = [:skip_conditions, :allowed_clock_drift, :matches_request_id, :skip_subject_confirmation].freeze
 
       option :name_identifier_format, nil

spec/omniauth/strategies/saml_spec.rb

@@ -222,4 +222,11 @@ def post_xml(xml=:example_response)
   it 'implements #on_metadata_path?' do
     expect(described_class.new(nil)).to respond_to(:on_metadata_path?)
   end
+
+  describe 'subclass behavior' do
+    it 'registers subclasses in OmniAuth.strategies' do
+      subclass = Class.new(described_class)
+      expect(OmniAuth.strategies).to include(described_class, subclass)
+    end
+  end
 end