Merge pull request #92 from rnubel/extract-metadata-path-check

Extract metadata route logic to a separate method

Author: bufferoverflow

.travis.yml

@@ -3,6 +3,7 @@ env:
     - JRUBY_OPTS="$JRUBY_OPTS --debug"
 language: ruby
 script: bundle exec rspec
+before_install: gem update bundler
 matrix:
   include:
     - rvm: 1.9.3

lib/omniauth/strategies/saml.rb

@@ -96,8 +96,12 @@ def response_fingerprint
         Digest::SHA1.hexdigest(cert.to_der).upcase.scan(/../).join(':')
       end
 
+      def on_metadata_path?
+        on_path?("#{request_path}/metadata")
+      end
+
       def other_phase
-        if on_path?("#{request_path}/metadata")
+        if on_metadata_path?
           # omniauth does not set the strategy on the other_phase
           @env['omniauth.strategy'] ||= self
           setup_phase

spec/omniauth/strategies/saml_spec.rb

@@ -218,4 +218,8 @@ def post_xml(xml=:example_response)
       last_response.body.should match /Required attributes/
     end
   end
+
+  it 'implements #on_metadata_path?' do
+    expect(described_class.new(nil)).to respond_to(:on_metadata_path?)
+  end
 end