Skip to content

Commit 00819ed

Browse files
committed
Check user perms in new tables
Signed-off-by: Dennis Wambua <[email protected]>
1 parent d192c13 commit 00819ed

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

Diff for: onadata/apps/api/management/commands/reassign_permission.py

+4-10
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
from django.core.management.base import BaseCommand, CommandError
44
from django.contrib.auth.models import User
5-
from django.contrib.contenttypes.models import ContentType
65
from django.utils.translation import gettext as _
76
from django.conf import settings
87
from onadata.apps.api.models import Team
@@ -60,8 +59,6 @@ def reassign_perms(self, user, app, model, new_perm):
6059
:param new_perm:
6160
:return:
6261
"""
63-
cont_type = ContentType.objects.get(app_label=app,
64-
model=model)
6562

6663
# Get the unique permission model objects filtered by content type
6764
# for the user
@@ -73,9 +70,10 @@ def reassign_perms(self, user, app, model, new_perm):
7370
objects = user.xformgroupobjectpermission_set.filter(
7471
group_id=user.pk).distinct('content_object_id')
7572
else:
76-
objects = \
77-
user.userobjectpermission_set.filter(content_type=cont_type)\
78-
.distinct('object_pk')
73+
if model == 'project':
74+
objects = user.projectuserobjectpermission_set.all()
75+
else:
76+
objects = user.xformuserobjectpermission_set.all()
7977

8078
for perm_obj in objects:
8179
obj = perm_obj.content_object
@@ -95,10 +93,6 @@ def reassign_perms(self, user, app, model, new_perm):
9593
if self.check_role(role_class, user, obj, new_perm):
9694
# If true
9795
role_class.add(user, obj)
98-
99-
if isinstance(user, Team):
100-
for user in user.user_set.all():
101-
role_class.add(user, obj)
10296
break
10397

10498
def check_role(self, role_class, user, obj, new_perm=[]):

0 commit comments

Comments
 (0)