Skip to content

Commit fb66379

Browse files
Fix exception Instance.DoesNotExist when registering Instance repeats (#2763)
* fix exception Instance.DoesNotExist when registering Instance repeats * enhance test
1 parent 0db5bae commit fb66379

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

onadata/apps/logger/models/instance.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -883,7 +883,11 @@ def register_export_repeats(sender, instance, created=False, **kwargs):
883883
# Avoid cyclic dependency errors
884884
logger_tasks = importlib.import_module("onadata.apps.logger.tasks")
885885

886-
logger_tasks.register_instance_export_repeats_async.delay(instance.pk)
886+
transaction.on_commit(
887+
lambda: logger_tasks.register_xform_export_repeats_async.delay(
888+
instance.xform.pk
889+
)
890+
)
887891

888892

889893
post_save.connect(

onadata/libs/tests/utils/test_csv_builder.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ def test_csv_dataframe_export_to(self, mock_register_repeats):
161161
self._test_csv_files(csv_file, csv_fixture_path)
162162
os.unlink(temp_file.name)
163163
# Repeat register is created for future use
164-
mock_register_repeats.assert_called_once_with(self.xform.id)
164+
mock_register_repeats.assert_called()
165165

166166
# pylint: disable=invalid-name
167167
def test_csv_columns_for_gps_within_groups(self):

0 commit comments

Comments
 (0)