Skip to content

Commit 51d1c09

Browse files
authored
Merge pull request #1169 from martygrant/martin/nativeCPUFixes
[NATIVECPU] Fix coverity warnings
2 parents dcec3fe + 4d63ae9 commit 51d1c09

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

source/adapters/native_cpu/enqueue.cpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ struct NDRDescT {
2525
RangeT GlobalSize;
2626
RangeT LocalSize;
2727
NDRDescT(uint32_t WorkDim, const size_t *GlobalWorkOffset,
28-
const size_t *GlobalWorkSize, const size_t *LocalWorkSize) {
28+
const size_t *GlobalWorkSize, const size_t *LocalWorkSize)
29+
: WorkDim(WorkDim) {
2930
for (uint32_t I = 0; I < WorkDim; I++) {
3031
GlobalOffset[I] = GlobalWorkOffset[I];
3132
GlobalSize[I] = GlobalWorkSize[I];

source/adapters/native_cpu/kernel.cpp

-1
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ UR_APIEXPORT ur_result_t UR_APICALL urKernelGetInfo(ur_kernel_handle_t hKernel,
9797
default:
9898
return UR_RESULT_ERROR_INVALID_VALUE;
9999
}
100-
DIE_NO_IMPLEMENTATION
101100
}
102101

103102
UR_APIEXPORT ur_result_t UR_APICALL

source/adapters/native_cpu/kernel.hpp

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
#include "common.hpp"
1414
#include "nativecpu_state.hpp"
1515
#include <ur_api.h>
16+
#include <utility>
1617

1718
namespace native_cpu {
1819

@@ -39,7 +40,7 @@ struct local_arg_info_t {
3940
struct ur_kernel_handle_t_ : RefCounted {
4041

4142
ur_kernel_handle_t_(const char *name, nativecpu_task_t subhandler)
42-
: _name{name}, _subhandler{subhandler} {}
43+
: _name{name}, _subhandler{std::move(subhandler)} {}
4344

4445
const char *_name;
4546
nativecpu_task_t _subhandler;

source/adapters/native_cpu/memory.hpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ struct _ur_buffer final : ur_mem_handle_t_ {
6868
bool isSubBuffer() const { return SubBuffer.Parent != nullptr; }
6969

7070
struct BB {
71-
BB(_ur_buffer *b) : Parent(b) {}
71+
BB(_ur_buffer *b) : Parent(b), Origin(0) {}
7272
BB() : BB(nullptr) {}
7373
_ur_buffer *const Parent;
7474
size_t Origin; // only valid if Parent != nullptr

0 commit comments

Comments
 (0)