Merge pull request #6444 from onflow/jord/backport-en-fetch-collection-10s

jordanschalm · web-flow · commit 426f64071f75 · 2024-09-09T22:29:19.000Z
Lower retry interval in EN requester engine
diff --git a/cmd/execution_builder.go b/cmd/execution_builder.go
@@ -1048,6 +1048,9 @@ func (exeNode *ExecutionNode) LoadIngestionEngine(
 			// consistency of collection can be checked by checking hash, and hash comes from trusted source (blocks from consensus follower)
 			// hence we not need to check origin
 			requester.WithValidateStaking(false),
+			// we have observed execution nodes occasionally fail to retrieve collections using this engine, which can cause temporary execution halts
+			// setting a retry maximum of 10s results in a much faster recovery from these faults (default is 2m)
+			requester.WithRetryMaximum(10*time.Second),
 		)
 
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -1048,6 +1048,9 @@ func (exeNode *ExecutionNode) LoadIngestionEngine(`
`1048`	`1048`	`// consistency of collection can be checked by checking hash, and hash comes from trusted source (blocks from consensus follower)`
`1049`	`1049`	`// hence we not need to check origin`
`1050`	`1050`	`requester.WithValidateStaking(false),`
	`1051`	`+ // we have observed execution nodes occasionally fail to retrieve collections using this engine, which can cause temporary execution halts`
	`1052`	`+ // setting a retry maximum of 10s results in a much faster recovery from these faults (default is 2m)`
	`1053`	`+ requester.WithRetryMaximum(10*time.Second),`
`1051`	`1054`	`)`
`1052`	`1055`
`1053`	`1056`	`if err != nil {`