Skip to content

Commit c80c420

Browse files
Apply suggestions from code review
Co-authored-by: Yurii Oleksyshyn <[email protected]>
1 parent a0e0d8d commit c80c420

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

storage/approvals.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
type ResultApprovals interface {
1717

1818
// Store stores a ResultApproval by its ID.
19+
// No errors are expected during normal operations.
1920
Store(result *flow.ResultApproval) error
2021

2122
// Index indexes a ResultApproval by result ID and chunk index.
@@ -30,13 +31,14 @@ type ResultApprovals interface {
3031
// still the method succeeds on each call. However, when attempting to index *different* ResultApproval IDs
3132
// for the same key (resultID, chunkIndex) this method returns an exception, as this should never happen for
3233
// a correct Verification Node indexing its own approvals.
34+
// No errors are expected during normal operations.
3335
Index(resultID flow.Identifier, chunkIndex uint64, approvalID flow.Identifier) error
3436

3537
// ByID retrieves a ResultApproval by its ID.
36-
// Returns `storage.ErrNotFound` if no Approval with the given ID has been stored.
38+
// Returns [storage.ErrNotFound] if no Approval with the given ID has been stored.
3739
ByID(approvalID flow.Identifier) (*flow.ResultApproval, error)
3840

3941
// ByChunk retrieves a ResultApproval by result ID and chunk index.
40-
// Returns `storage.ErrNotFound` if no Approval for the given key (resultID, chunkIndex) has been stored.
42+
// Returns [storage.ErrNotFound] if no Approval for the given key (resultID, chunkIndex) has been stored.
4143
ByChunk(resultID flow.Identifier, chunkIndex uint64) (*flow.ResultApproval, error)
4244
}

0 commit comments

Comments
 (0)