Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Compatible Range in node version info does not reflect compatibility overrides #7014

Open
peterargue opened this issue Feb 11, 2025 · 0 comments
Labels
Bug Something isn't working S-Access

Comments

@peterargue
Copy link
Contributor

The Access API's node version info endpoint includes the range of blocks that the node's version is compatible with

if b.versionControl != nil {
compatibleRange = &access.CompatibleRange{
StartHeight: b.versionControl.StartHeight(),
EndHeight: b.versionControl.EndHeight(),
}
}

$ curl "http://access-001.devnet52.nodes.onflow.org:8070/v1/node_version_info"                                                    
{
        "semver": "v0.38.1",
        "commit": "1bfbed9de87fff55e551ac97ffec3f758653d4b1",
        "spork_id": "5b88b81cfce2619305213489c2137f98e6efa0ec333dab2c31042b743388a3ce",
        "protocol_version": "36",
        "spork_root_block_height": "218215349",
        "node_root_block_height": "218215349",
        "compatible_range": {
                "start_height": "242365900",
                "end_height": "242374176"
        }
}

This does not reflect the compatibility overrides:

var defaultCompatibilityOverrides = map[string]struct{}{
"0.37.17": {},
"0.37.18": {},
"0.37.22": {},
"0.37.26": {},
"0.38.0": {},
}

@peterargue peterargue added Bug Something isn't working S-Access labels Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working S-Access
Projects
None yet
Development

No branches or pull requests

1 participant