Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Data providers should wrap context.Canceled error #7040

Open
illia-malachyn opened this issue Feb 14, 2025 · 0 comments · May be fixed by #7046
Open

[Access] Data providers should wrap context.Canceled error #7040

illia-malachyn opened this issue Feb 14, 2025 · 0 comments · May be fixed by #7046
Assignees
Labels

Comments

@illia-malachyn
Copy link
Contributor

When an issue occurs with a streamer or subscription, and the associated context is canceled, data providers return a context.Canceled error to the WebSocket controller. This is unintended because context.Canceled should only originate from the controller itself.

As a result, user subscriptions may silently shut down without any explicit error or notice, making it difficult to diagnose the issue.

Expected Behavior

  • Data providers should verify the actual error returned by the subscription or streamer.
  • If the error is context.Canceled, they should wrap it in a more meaningful error before passing it to the WebSocket controller.

This ensures that cancellations triggered internally are distinguishable from those initiated by the controller, preventing silent failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant