Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Investigate gorrilla ReadJSON return error on Close #7045

Open
Guitarheroua opened this issue Feb 17, 2025 · 0 comments · May be fixed by #7065
Open

[Access] Investigate gorrilla ReadJSON return error on Close #7045

Guitarheroua opened this issue Feb 17, 2025 · 0 comments · May be fixed by #7065
Assignees
Labels

Comments

@Guitarheroua
Copy link
Contributor

Due to comment #6907 (comment) we should remove duplication of error handling in WS controller code:

if err := c.conn.ReadJSON(&message); err != nil {
    // The check in `if` statement below should be removed
    if errors.Is(err, websocket.ErrCloseSent) {
	return err
    }
    var closeErr *websocket.CloseError
    if errors.As(err, &closeErr) {
        return err
    }

But we should ensure that ReadJSON always return *websocket.CloseError on close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants