We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReadJSON
Due to comment #6907 (comment) we should remove duplication of error handling in WS controller code:
if err := c.conn.ReadJSON(&message); err != nil { // The check in `if` statement below should be removed if errors.Is(err, websocket.ErrCloseSent) { return err } var closeErr *websocket.CloseError if errors.As(err, &closeErr) { return err }
But we should ensure that ReadJSON always return *websocket.CloseError on close.
*websocket.CloseError
The text was updated successfully, but these errors were encountered:
illia-malachyn
Successfully merging a pull request may close this issue.
Due to comment #6907 (comment) we should remove duplication of error handling in WS controller code:
But we should ensure that
ReadJSON
always return*websocket.CloseError
on close.The text was updated successfully, but these errors were encountered: