Skip to content

Commit 4d565cf

Browse files
Apply suggestions from code review
Co-authored-by: Joshua Hannan <[email protected]>
1 parent d11f5e0 commit 4d565cf

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

contracts/CrossVMMetadataViews.cdc

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import "EVM"
22

33
/// This contract implements views originally proposed in FLIP-318 supporting NFT collections
44
/// with project-defined implementations across both Cadence & EVM.
5-
///
5+
/// The View structs in this contract should be implemented in the same way that views from `MetadataViews` are implemented
6+
///
67
access(all) contract CrossVMMetadataViews {
78

89
/// An enum denoting a VM. For now, there are only two VMs on Flow, but this enum could be
@@ -20,14 +21,14 @@ access(all) contract CrossVMMetadataViews {
2021
/// information and context, see FLIP-318: https://github.com/onflow/flips/issues/318
2122
///
2223
access(all) struct EVMPointer {
23-
/// The associated Cadence Type
24+
/// The associated Cadence Type defined in the contract that this view is returned from
2425
access(all) let cadenceType: Type
2526
/// The defining Cadence contract address
2627
access(all) let cadenceContractAddress: Address
27-
/// The associated EVM contract address
28+
/// The associated EVM contract address that the Cadence contract will bridge to
2829
access(all) let evmContractAddress: EVM.EVMAddress
2930
/// Whether the asset is Cadence- or EVM-native. Native here meaning the VM in which the
30-
/// asset is distributed.
31+
/// asset is originally distributed.
3132
access(all) let nativeVM: VM
3233

3334
init(

0 commit comments

Comments
 (0)