Skip to content

Commit b9f2591

Browse files
authored
Fix CI PR workflow
* Default value is boolean * Comparison is against boolean
1 parent ef1a52e commit b9f2591

File tree

1 file changed

+31
-31
lines changed

1 file changed

+31
-31
lines changed

.github/workflows/ci.yml

+31-31
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ on:
1919
type: boolean
2020
description: Skip Artifactory publish and Docker push for all apps
2121
required: false
22-
default: 'false'
22+
default: false
2323
secrets:
2424
JF_ARTIFACTORY_SPRING:
2525
description: 'encoded JFrog server id configuration'
@@ -41,7 +41,7 @@ jobs:
4141
with:
4242
app-dir: 'kafka-samples'
4343
mvn-build-commands: '-B clean verify -Pspring'
44-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
44+
artifactory-publish: ${{ inputs.maven-build-only != true }}
4545
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
4646

4747
multi-io-ticktock:
@@ -61,7 +61,7 @@ jobs:
6161
with:
6262
app-dir: 'multi-io-samples/purchase-orders/http-purchase-orders'
6363
mvn-build-commands: '-B clean install jib:dockerBuild'
64-
docker-push: ${{ inputs.maven-build-only != 'true' }}
64+
docker-push: ${{ inputs.maven-build-only != true }}
6565
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
6666
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
6767
docker-images: >-
@@ -75,9 +75,9 @@ jobs:
7575
with:
7676
app-dir: 'multi-io-samples/kafka-streams/user-clicks-per-region-1.2.x'
7777
mvn-build-commands: '-B clean install jib:dockerBuild -pl http-click-ingest,http-region-ingest,http-clicks-and-region-ingest,user-clicks-per-region-processor,log-user-clicks-per-region'
78-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
78+
artifactory-publish: ${{ inputs.maven-build-only != true }}
7979
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
80-
docker-push: ${{ inputs.maven-build-only != 'true' }}
80+
docker-push: ${{ inputs.maven-build-only != true }}
8181
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
8282
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
8383
docker-images: >-
@@ -95,7 +95,7 @@ jobs:
9595
with:
9696
app-dir: 'function-samples'
9797
mvn-build-commands: '-B clean verify -Pspring'
98-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
98+
artifactory-publish: ${{ inputs.maven-build-only != true }}
9999
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
100100

101101
function-samples-uppercase-processor:
@@ -106,9 +106,9 @@ jobs:
106106
with:
107107
app-dir: 'function-samples/uppercase-processor'
108108
mvn-build-commands: '-B clean install jib:dockerBuild'
109-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
109+
artifactory-publish: ${{ inputs.maven-build-only != true }}
110110
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
111-
docker-push: ${{ inputs.maven-build-only != 'true' }}
111+
docker-push: ${{ inputs.maven-build-only != true }}
112112
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
113113
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
114114
docker-images: >-
@@ -122,9 +122,9 @@ jobs:
122122
with:
123123
app-dir: 'dataflow-website/stream-developer-guides/streams/standalone-stream-sample'
124124
mvn-build-commands: '-B clean install jib:dockerBuild'
125-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
125+
artifactory-publish: ${{ inputs.maven-build-only != true }}
126126
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
127-
docker-push: ${{ inputs.maven-build-only != 'true' }}
127+
docker-push: ${{ inputs.maven-build-only != true }}
128128
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
129129
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
130130
docker-images: >-
@@ -140,10 +140,10 @@ jobs:
140140
with:
141141
app-dir: 'dataflow-website/stream-developer-guides/streams/standalone-stream-sample'
142142
mvn-build-commands: '-B clean install -Prabbit jib:dockerBuild'
143-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
143+
artifactory-publish: ${{ inputs.maven-build-only != true }}
144144
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
145145
jf-mvn-build-commands: '-B clean install -Prabbit -DskipTests'
146-
docker-push: ${{ inputs.maven-build-only != 'true' }}
146+
docker-push: ${{ inputs.maven-build-only != true }}
147147
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
148148
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
149149
docker-images: >-
@@ -159,14 +159,14 @@ jobs:
159159
with:
160160
app-dir: 'dataflow-website/batch-developer-guides/batch/batchsamples'
161161
mvn-build-commands: '-B clean install spring-boot:build-image -Dspring-boot.build-image.imageName=springcloudtask/billsetuptask:0.0.1-SNAPSHOT'
162-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
162+
artifactory-publish: ${{ inputs.maven-build-only != true }}
163163
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
164-
docker-push: ${{ inputs.maven-build-only != 'true' }}
164+
docker-push: ${{ inputs.maven-build-only != true }}
165165
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
166166
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
167167
docker-images: >-
168168
springcloudtask/billsetuptask:0.0.1-SNAPSHOT
169-
169+
170170
stream-dev-guides-composed-http-transformer-kafka:
171171
runs-on: ubuntu-latest
172172
steps:
@@ -175,9 +175,9 @@ jobs:
175175
with:
176176
app-dir: 'dataflow-website/stream-developer-guides/feature-guides/streams/function-composition/composed-http-transformer-kafka'
177177
mvn-build-commands: '-B clean install jib:dockerBuild'
178-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
178+
artifactory-publish: ${{ inputs.maven-build-only != true }}
179179
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
180-
docker-push: ${{ inputs.maven-build-only != 'true' }}
180+
docker-push: ${{ inputs.maven-build-only != true }}
181181
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
182182
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
183183
docker-images: >-
@@ -191,9 +191,9 @@ jobs:
191191
with:
192192
app-dir: 'dataflow-website/stream-developer-guides/feature-guides/streams/function-composition/composed-http-transformer-kotlin-kafka'
193193
mvn-build-commands: '-B clean install jib:dockerBuild'
194-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
194+
artifactory-publish: ${{ inputs.maven-build-only != true }}
195195
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
196-
docker-push: ${{ inputs.maven-build-only != 'true' }}
196+
docker-push: ${{ inputs.maven-build-only != true }}
197197
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
198198
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
199199
docker-images: >-
@@ -207,9 +207,9 @@ jobs:
207207
with:
208208
app-dir: 'dataflow-website/stream-developer-guides/feature-guides/streams/function-composition/composed-http-transformer-rabbitmq'
209209
mvn-build-commands: '-B clean install jib:dockerBuild'
210-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
210+
artifactory-publish: ${{ inputs.maven-build-only != true }}
211211
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
212-
docker-push: ${{ inputs.maven-build-only != 'true' }}
212+
docker-push: ${{ inputs.maven-build-only != true }}
213213
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
214214
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
215215
docker-images: >-
@@ -223,9 +223,9 @@ jobs:
223223
with:
224224
app-dir: 'dataflow-website/stream-developer-guides/feature-guides/streams/function-composition/composed-http-transformer-kotlin-rabbitmq'
225225
mvn-build-commands: '-B clean install jib:dockerBuild'
226-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
226+
artifactory-publish: ${{ inputs.maven-build-only != true }}
227227
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
228-
docker-push: ${{ inputs.maven-build-only != 'true' }}
228+
docker-push: ${{ inputs.maven-build-only != true }}
229229
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
230230
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
231231
docker-images: >-
@@ -239,9 +239,9 @@ jobs:
239239
with:
240240
app-dir: 'monitoring-samples/task-apps/task-demo-metrics-prometheus'
241241
mvn-build-commands: '-B clean install docker:build'
242-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
242+
artifactory-publish: ${{ inputs.maven-build-only != true }}
243243
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
244-
docker-push: ${{ inputs.maven-build-only != 'true' }}
244+
docker-push: ${{ inputs.maven-build-only != true }}
245245
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
246246
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
247247
docker-images: >-
@@ -255,9 +255,9 @@ jobs:
255255
with:
256256
app-dir: 'scenario-task'
257257
mvn-build-commands: '-B clean install spring-boot:build-image -Dspring-boot.build-image.imageName=springcloudtask/scenario-task:0.0.1-SNAPSHOT'
258-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
258+
artifactory-publish: ${{ inputs.maven-build-only != true }}
259259
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
260-
docker-push: ${{ inputs.maven-build-only != 'true' }}
260+
docker-push: ${{ inputs.maven-build-only != true }}
261261
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
262262
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
263263
docker-images: >-
@@ -271,9 +271,9 @@ jobs:
271271
with:
272272
app-dir: 'timestamp-task'
273273
mvn-build-commands: '-B clean install spring-boot:build-image -Dspring-boot.build-image.imageName=springcloudtask/timestamp-task:1.0.0'
274-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
274+
artifactory-publish: ${{ inputs.maven-build-only != true }}
275275
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
276-
docker-push: ${{ inputs.maven-build-only != 'true' }}
276+
docker-push: ${{ inputs.maven-build-only != true }}
277277
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
278278
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
279279
docker-images: >-
@@ -287,9 +287,9 @@ jobs:
287287
with:
288288
app-dir: 'timestamp-batch'
289289
mvn-build-commands: '-B clean install spring-boot:build-image -Dspring-boot.build-image.imageName=springcloudtask/timestamp-batch-task:1.0.0'
290-
artifactory-publish: ${{ inputs.maven-build-only != 'true' }}
290+
artifactory-publish: ${{ inputs.maven-build-only != true }}
291291
jf-artifactory-spring: ${{ secrets.JF_ARTIFACTORY_SPRING }}
292-
docker-push: ${{ inputs.maven-build-only != 'true' }}
292+
docker-push: ${{ inputs.maven-build-only != true }}
293293
docker-username: ${{ secrets.DOCKERHUB_USERNAME }}
294294
docker-password: ${{ secrets.DOCKERHUB_TOKEN }}
295295
docker-images: >-

0 commit comments

Comments
 (0)