Onyx::SQL.transaction must not affect the repo

[vladfaust]

2.times do
  spawn do
    Onyx::SQL.transaction do |tx|
      sleep(rand)
      Onyx::SQL.query # Which tx is it using now – the first or the second one?
    end
  end
end

Proposed API:

Onyx::SQL.transaction do |tx|
  repo = Onyx::SQL.repo.dup
  repo.db = tx # Should patch Onyx::SQL for that
  repo.query() # Instead of Onyx::SQL.query
  # The tx is commited in the end as before
end

[repomaa]

how about:

Onyx::SQL.transaction do |tx|
  tx.query(...)
end

tx wouldn't be a DB::Transaction in this case but rather the duplicated repo
with db set to the DB::Transaction. This way it would mask the internals from
the API users and it'd be quite intuitive to use.

[repomaa]

Is this Onyx::SQL.transaction method currently implemented? I didn't find anything in the onyx-sql repo

[vladfaust]

@repomaa the definition is here:

onyx/src/onyx/sql.cr

Line 47 in 9402f0a

def self.transaction(&block : ::DB::Transaction ->)

[repomaa]

hm, any reason why it isn't defined in the Onyx::SQL repo?

[vladfaust]

@repomaa yes, because onyx/onyx is a higher-level framework, and onyx/sql is an ORM