refactor(install)!: not install new dep when miss version (#12)

Signed-off-by: Kevin Cui <[email protected]>

Author: BlackHole1

src/cmd/install.test.ts

@@ -252,10 +252,10 @@ describe.sequential("install deps", () => {
         });
 
         expect(result.deps).toStrictEqual({
-            "a-0.0.2": {
+            "a-0.0.1": {
                 name: "a",
-                version: "0.0.2",
-                isAlreadyExist: false,
+                version: "0.0.1",
+                isAlreadyExist: true,
                 target: expect.any(String),
                 meta: expect.any(Object),
             },
@@ -284,7 +284,7 @@ describe.sequential("install deps", () => {
 
         const deps = (await generatePackageJson(ctx.workdir, false)).dependencies;
         expect(deps).toEqual({
-            a: "0.0.2",
+            a: "0.0.1",
             b: "0.0.2",
             c: "0.0.1",
             d: "0.0.1",
@@ -298,7 +298,6 @@ describe.sequential("install deps", () => {
 
         expect(new Set(fileList)).toEqual(new Set([
             "a-0.0.1/package.oo.yaml",
-            "a-0.0.2/package.oo.yaml",
             "b-0.0.2/package.oo.yaml",
             "c-0.0.1/package.oo.yaml",
             "d-0.0.1/package.oo.yaml",

src/cmd/install.ts

@@ -110,7 +110,12 @@ export async function installPackage(options: InstallPackageOptions): Promise<In
             let version = dep.version;
 
             if (!version) {
-                version = await findLatestVersion(dep.name, options.token);
+                if (libraryMeta?.dependencies?.[dep.name]) {
+                    version = libraryMeta?.dependencies?.[dep.name] as string;
+                }
+                else {
+                    version = await findLatestVersion(dep.name, options.token);
+                }
             }
 
             const existsDisk = await exists(path.join(options.distDir, `${dep.name}-${version}`, ooPackageName));

tests/fixtures/install_deps/README.md

@@ -26,9 +26,9 @@ d: 0.0.1
 ### Installation Logic
 
 1. Install `a` `b` `c:0.0.1`
-2. Will install `a:0.0.2` `b:0.0.2` `c:0.0.1` `d:0.0.1`
+2. Will install `b:0.0.2` `c:0.0.1` `d:0.0.1`
    1. Install `d:0.0.1` when not found in `Local Storage`
-3. Update entry dependencies `a` to `0.0.2`
-4. Add `b:0.0.2` to entry dependencies and `Local Storage`
-5. Add `c:0.0.1` to entry dependencies and `Local Storage`
-6. Add `d:0.0.1` to entry dependencies and `Local Storage` (Overwrite)
+   2. Not install `a:0.0.2` as `a:0.0.1` is already installed
+3. Add `b:0.0.2` to entry dependencies and `Local Storage`
+4. Add `c:0.0.1` to entry dependencies and `Local Storage`
+5. Add `d:0.0.1` to entry dependencies and `Local Storage` (Overwrite)