Add import linters #5134
Merged
Add import linters #5134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEPENDENCY
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds import linting to enforce architectural boundaries and dependency rules in the backend codebase using import-linter. It establishes five contracts that prevent circular dependencies and maintain proper layering between modules.
Key Changes:
- Added import-linter as a dev dependency and configured five architectural contracts
- Integrated import-linter into pre-commit hooks and CI/CD pipeline
- Added cache file to .gitignore
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| application/backend/pyproject.toml | Added import-linter dependency and configured five architectural contracts (main_app, api, core_module, schema_model, service_utils) |
| application/backend/.pre-commit-config.yaml | Added import-linter pre-commit hook with --no-cache flag |
| application/backend/.gitignore | Added .import_linter_cache to ignored files |
| .github/workflows/backend-lint-and-test.yaml | Added import-linter check step to CI pipeline |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
leoll2
reviewed
Jan 6, 2026
Contributor
leoll2
left a comment
leoll2
left a comment
There was a problem hiding this comment.
Nice setup, only one suggestion
leoll2
approved these changes
Jan 6, 2026
AlexanderBarabanov
approved these changes
Jan 6, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added contracts:
App Main Vertical (main_app) - Enforces layered architecture:
api → services → repositories → db. Ensures proper dependency flow from presentation to data layer.Internal API (api) - Controls API module structure:
routers → serializers → schemas → dependencies. Keeps API concerns properly separated.Core Module (core_module) - Layers within core:
jobs → run → models → logging. Ensures core utilities don't have circular dependencies.Schema-Model (schema_model) - Ensures
app.schemassits above bothapp.core.modelsandapp.models. Prevents schema layer from being imported by model layers.Service-Utils (service_utils) -
services → utils. Utilities should be lower-level, imported by services but not vice versa.How to test
uv run lint-importsChecklist