-
Notifications
You must be signed in to change notification settings - Fork 462
Add endpoint for updating model name #5166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds functionality to rename model revisions through a new PATCH endpoint, enabling clients to update a model's name by its ID.
Changes:
- Added a PATCH endpoint to support renaming model revisions
- Implemented service layer logic to handle model name updates with proper error handling
- Added integration test coverage for the new update functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| application/docker/Dockerfile | Updated libglib2.0 package version to newer release |
| application/backend/app/api/routers/models.py | Added new PATCH endpoint for renaming models with OpenAPI documentation |
| application/backend/app/services/model_service.py | Implemented update_model method to handle model name updates |
| application/backend/tests/integration/services/test_model_service.py | Added integration test to verify model name update functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leoll2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor suggestion, LGTM
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@JortBergfeld I've opened a new pull request, #5174, to work on those changes. Once the pull request is ready, I'll request review from you. |
f7e061d to
34e6188
Compare
34e6188 to
031c8a6
Compare
Signed-off-by: Jort Bergfeld <[email protected]>
Signed-off-by: Jort Bergfeld <[email protected]>
Signed-off-by: Jort Bergfeld <[email protected]>
3aadc22 to
0c892d5
Compare
This pull request adds support for renaming a model revision by its ID through a new PATCH endpoint, updates the service layer to handle model name updates, and introduces an integration test to verify this new functionality.
API Enhancements:
/{model_id}) torouters/models.pyallowing clients to rename a model revision, including OpenAPI documentation and request body examples. [1] [2]Service Layer Updates:
rename_modelmethod inModelServiceto update a model revision's name, with proper error handling if the model is not found.Testing:
test_update_modelto ensure the model name update functionality works as expected.Resolves #5057
How to test
Added integration test for update_model
Checklist