Add query param for dataset revision to filter models on dataset #5185
+79
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jort Bergfeld <[email protected]>
Signed-off-by: Jort Bergfeld <[email protected]>
github-actions
bot
added
TEST
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the ability to filter models by dataset revision when listing models in a project. The change enables API consumers to retrieve only models trained on a specific dataset revision rather than all models in a project.
Changes:
- Added optional
dataset_revision_idquery parameter to the models listing endpoint - Extended service and repository layers to support filtering by training dataset ID
- Added integration test to verify the filtering behavior
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| application/backend/app/api/routers/models.py | Added optional dataset_revision_id query parameter to list_models endpoint |
| application/backend/app/services/model_service.py | Updated list_models method signature to accept and pass through dataset_revision_id filter |
| application/backend/app/repositories/model_revision_repo.py | Modified list_all to support filtering by training_dataset_id |
| application/backend/tests/integration/services/test_model_service.py | Added integration test verifying dataset revision filtering returns correct models |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📊 Test coverage report
|
Docker Image SizesCPU
GPU
XPU
|
Signed-off-by: Jort Bergfeld <[email protected]>
leoll2
reviewed
Jan 14, 2026
Signed-off-by: Jort Bergfeld <[email protected]>
Contributor
Author
|
@copilot open a new pull request to apply changes based on the comments in this thread |
5 tasks
|
@JortBergfeld I've opened a new pull request, #5187, to work on those changes. Once the pull request is ready, I'll request review from you. |
…leanup (#5187) Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JortBergfeld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the ability to filter models by dataset revision in the API, service, and repository layers. It also adds an integration test to verify this new functionality. The main changes are grouped below:
API and Schema Enhancements
dataset_revision_idquery parameter to thelist_modelsendpoint inmodels.py, allowing clients to filter models by a specific dataset revision. The endpoint and its docstring were updated accordingly. [1] [2]Service and Repository Layer Updates
ModelService.list_modelsmethod to accept an optionaldataset_revision_idparameter and pass it to the repository, filtering models as needed. [1] [2]ModelRevisionRepository.list_allmethod to support filtering model revisions bytraining_dataset_id(corresponding to the dataset revision).Testing Improvements
test_model_service.pyto verify that filtering models bydataset_revision_idreturns only the relevant models. [1] [2]Resolves #5153
How to test
Added integration tests.
Checklist