Check SerdesLock bit directly instead of relying on PortStatusCode

bparks13 · bparks13 · commit ab6a682a7494 · 2025-03-17T13:55:16.000-04:00
diff --git a/Source/Devices/PortController.cpp b/Source/Devices/PortController.cpp
@@ -74,12 +74,11 @@ void PortController::processFrames()
 		uint32_t code = (uint32_t) *(dataPtr + dataOffset);
 		uint32_t data = (uint32_t) *(dataPtr + dataOffset + 1);
 
-		if (code & (uint32_t)PortStatusCode::SerdesLock)
-			errorFlag = ((uint32_t)data & LINKSTATE_SL) == 0;
+		errorFlag = errorFlag || ((uint32_t)data & LINKSTATE_SL) == 0;
 
 		oni_destroy_frame(frame);
 
-		LOGE("Port status changed for " + getName() + ". Port status code is " + String((uint32_t)code));
+		LOGE("Port status changed for " + getName() + ".");
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -74,12 +74,11 @@ void PortController::processFrames()`
`74`	`74`	`uint32_t code = (uint32_t) *(dataPtr + dataOffset);`
`75`	`75`	`uint32_t data = (uint32_t) *(dataPtr + dataOffset + 1);`
`76`	`76`
`77`		`- if (code & (uint32_t)PortStatusCode::SerdesLock)`
`78`		`- errorFlag = ((uint32_t)data & LINKSTATE_SL) == 0;`
	`77`	`+ errorFlag = errorFlag \|\| ((uint32_t)data & LINKSTATE_SL) == 0;`
`79`	`78`
`80`	`79`	`oni_destroy_frame(frame);`
`81`	`80`
`82`		`- LOGE("Port status changed for " + getName() + ". Port status code is " + String((uint32_t)code));`
	`81`	`+ LOGE("Port status changed for " + getName() + ".");`
`83`	`82`	`}`
`84`	`83`	`}`
`85`	`84`