Skip to content

Commit a83c770

Browse files
committed
Added missing parameter comments
1 parent 2c9a3eb commit a83c770

File tree

5 files changed

+31
-31
lines changed

5 files changed

+31
-31
lines changed

OpenEphys.ProbeInterface.NET/Contact.cs

+12-12
Original file line numberDiff line numberDiff line change
@@ -48,24 +48,24 @@ public readonly struct Contact
4848
/// <summary>
4949
/// Initializes a new instance of the <see cref="Contact"/> struct.
5050
/// </summary>
51-
/// <param name="posX"></param>
52-
/// <param name="posY"></param>
53-
/// <param name="shape"></param>
54-
/// <param name="shapeParam"></param>
55-
/// <param name="device_id"></param>
56-
/// <param name="contact_id"></param>
57-
/// <param name="shank_id"></param>
58-
/// <param name="index"></param>
51+
/// <param name="posX">Center value of the contact on the X-axis.</param>
52+
/// <param name="posY">Center value of the contact on the Y-axis.</param>
53+
/// <param name="shape">The <see cref="ContactShape"/> of the contact.</param>
54+
/// <param name="shapeParam"><see cref="ContactShapeParam"/>'s relevant to the <see cref="ContactShape"/> of the contact.</param>
55+
/// <param name="deviceId">The device channel index (<see cref="Probe.DeviceChannelIndices"/>) of this contact.</param>
56+
/// <param name="contactId">The contact ID (<see cref="Probe.ContactIds"/>) of this contact.</param>
57+
/// <param name="shankId">The shank ID (<see cref="Probe.ShankIds"/>) of this contact.</param>
58+
/// <param name="index">The index of the contact within the context of the <see cref="Probe"/>.</param>
5959
public Contact(float posX, float posY, ContactShape shape, ContactShapeParam shapeParam,
60-
int device_id, string contact_id, string shank_id, int index)
60+
int deviceId, string contactId, string shankId, int index)
6161
{
6262
PosX = posX;
6363
PosY = posY;
6464
Shape = shape;
6565
ShapeParams = shapeParam;
66-
DeviceId = device_id;
67-
ContactId = contact_id;
68-
ShankId = shank_id;
66+
DeviceId = deviceId;
67+
ContactId = contactId;
68+
ShankId = shankId;
6969
Index = index;
7070
}
7171
}

OpenEphys.ProbeInterface.NET/ContactAnnotations.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class ContactAnnotations
1515
/// <summary>
1616
/// Initializes a new instance of the <see cref="ContactAnnotations"/> class.
1717
/// </summary>
18-
/// <param name="contactAnnotations"></param>
18+
/// <param name="contactAnnotations">Array of strings containing annotations for each contact. Size of the array should match the number of contacts, but they can be empty strings.</param>
1919
[JsonConstructor]
2020
public ContactAnnotations(string[] contactAnnotations)
2121
{

OpenEphys.ProbeInterface.NET/ContactShapeParam.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public ContactShapeParam(float? radius = null, float? width = null, float? heigh
5252
/// <summary>
5353
/// Copy constructor given an existing <see cref="ContactShapeParam"/> object.
5454
/// </summary>
55-
/// <param name="shape"></param>
55+
/// <param name="shape">Existing <see cref="ContactShapeParam"/> object to be copied.</param>
5656
protected ContactShapeParam(ContactShapeParam shape)
5757
{
5858
Radius = shape.Radius;

OpenEphys.ProbeInterface.NET/Probe.cs

+14-14
Original file line numberDiff line numberDiff line change
@@ -113,18 +113,18 @@ public class Probe
113113
/// <summary>
114114
/// Public constructor, defined as the default Json constructor.
115115
/// </summary>
116-
/// <param name="ndim"></param>
117-
/// <param name="si_units"></param>
118-
/// <param name="annotations"></param>
119-
/// <param name="contact_annotations"></param>
120-
/// <param name="contact_positions"></param>
121-
/// <param name="contact_plane_axes"></param>
122-
/// <param name="contact_shapes"></param>
123-
/// <param name="contact_shape_params"></param>
124-
/// <param name="probe_planar_contour"></param>
125-
/// <param name="device_channel_indices"></param>
126-
/// <param name="contact_ids"></param>
127-
/// <param name="shank_ids"></param>
116+
/// <param name="ndim">Number of dimensions to use while plotting the contacts [<see cref="ProbeNdim.Two"/> or <see cref="ProbeNdim.Three"/>].</param>
117+
/// <param name="si_units">Real-world units to use while plotting the contacts [<see cref="ProbeSiUnits.mm"/> or <see cref="ProbeSiUnits.um"/>].</param>
118+
/// <param name="annotations">Annotations for the probe.</param>
119+
/// <param name="contact_annotations">Annotations for each contact as an array of strings.</param>
120+
/// <param name="contact_positions">Center position of each contact in a two-dimensional array of floats. For more info, see <see cref="ContactPositions"/>.</param>
121+
/// <param name="contact_plane_axes">Plane axes of each contact in a three-dimensional array of floats. For more info, see <see cref="ContactPlaneAxes"/>.</param>
122+
/// <param name="contact_shapes">Array of shapes for each contact.</param>
123+
/// <param name="contact_shape_params">Array of shape parameters for the each contact.</param>
124+
/// <param name="probe_planar_contour">Two-dimensional array of floats (X and Y positions) defining a closed shape for a probe contour.</param>
125+
/// <param name="device_channel_indices">Array of integers containing the device channel indices for each contact. For more info, see <see cref="DeviceChannelIndices"/>.</param>
126+
/// <param name="contact_ids">Array of strings containing the contact ID for each contact. For more info, see <see cref="ContactIds"/>.</param>
127+
/// <param name="shank_ids">Array of strings containing the shank ID for each contact. For more info, see <see cref="ShankIds"/>.</param>
128128
[JsonConstructor]
129129
public Probe(ProbeNdim ndim, ProbeSiUnits si_units, ProbeAnnotations annotations, ContactAnnotations contact_annotations,
130130
float[][] contact_positions, float[][][] contact_plane_axes, ContactShape[] contact_shapes,
@@ -148,7 +148,7 @@ public Probe(ProbeNdim ndim, ProbeSiUnits si_units, ProbeAnnotations annotations
148148
/// <summary>
149149
/// Copy constructor given an existing <see cref="Probe"/> object.
150150
/// </summary>
151-
/// <param name="probe"></param>
151+
/// <param name="probe">Existing <see cref="Probe"/> object to be copied.</param>
152152
protected Probe(Probe probe)
153153
{
154154
NumDimensions = probe.NumDimensions;
@@ -252,7 +252,7 @@ public static ContactShapeParam[] DefaultRectParams(int numberOfContacts, float
252252

253253
for (int i = 0; i < numberOfContacts; i++)
254254
{
255-
contactShapeParams[i] = new ContactShapeParam(height: height);
255+
contactShapeParams[i] = new ContactShapeParam(width: width, height: height);
256256
}
257257

258258
return contactShapeParams;

OpenEphys.ProbeInterface.NET/ProbeAnnotations.cs

+3-3
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ public class ProbeAnnotations
2222
/// <summary>
2323
/// Initializes a new instance of the <see cref="ProbeAnnotations"/> class.
2424
/// </summary>
25-
/// <param name="name"></param>
26-
/// <param name="manufacturer"></param>
25+
/// <param name="name">String defining the name of the probe.</param>
26+
/// <param name="manufacturer">String defining the manufacturer of the probe.</param>
2727
[JsonConstructor]
2828
public ProbeAnnotations(string name, string manufacturer)
2929
{
@@ -34,7 +34,7 @@ public ProbeAnnotations(string name, string manufacturer)
3434
/// <summary>
3535
/// Copy constructor that copies data from an existing <see cref="ProbeAnnotations"/> object.
3636
/// </summary>
37-
/// <param name="probeAnnotations"></param>
37+
/// <param name="probeAnnotations">Existing <see cref="ProbeAnnotations"/> object, containing a <see cref="Name"/> and a <see cref="Manufacturer"/>.</param>
3838
protected ProbeAnnotations(ProbeAnnotations probeAnnotations)
3939
{
4040
Name = probeAnnotations.Name;

0 commit comments

Comments
 (0)