Skip to content

Commit 74e56e4

Browse files
committed
fixed lint issues
Signed-off-by: Michael Beemer <[email protected]>
1 parent bd6263e commit 74e56e4

File tree

5 files changed

+11
-13
lines changed

5 files changed

+11
-13
lines changed

libs/providers/flagd/src/e2e/setup-in-process-provider.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,8 @@ OpenFeature.setProvider(
1111
new FlagdProvider({ cache: 'disabled', resolverType: 'in-process', host: 'localhost', port: 9090 }),
1212
);
1313
OpenFeature.setProvider('unstable', new FlagdProvider({ resolverType: 'in-process', host: 'localhost', port: 9091 }));
14-
// TODO: update with correct assertions once we have ability to get providerMetadata for any provider
15-
// assert(
16-
// OpenFeature.providerMetadata.name === FLAGD_NAME,
17-
// new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
18-
// );
14+
assert(
15+
OpenFeature.providerMetadata.name === FLAGD_NAME,
16+
new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
17+
);
1918
console.log('flagd provider configured!');

libs/providers/flagd/src/e2e/setup-rpc-provider.ts

+4-5
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ const FLAGD_NAME = 'flagd Provider';
88
console.log('Setting flagd provider...');
99
OpenFeature.setProvider('e2e', new FlagdProvider({ cache: 'disabled' }));
1010
OpenFeature.setProvider('unstable', new FlagdProvider({ cache: 'disabled', port: 8014 }));
11-
// TODO: update with correct assertions once we have ability to get providerMetadata for any provider
12-
// assert(
13-
// OpenFeature.providerMetadata.name === FLAGD_NAME,
14-
// new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
15-
// );
11+
assert(
12+
OpenFeature.providerMetadata.name === FLAGD_NAME,
13+
new Error(`Expected ${FLAGD_NAME} provider to be configured, instead got: ${OpenFeature.providerMetadata.name}`),
14+
);
1615
console.log('flagd provider configured!');

libs/providers/flagd/src/e2e/step-definitions/flagd.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ defineFeature(feature, (test) => {
5252
then('the PROVIDER_CONFIGURATION_CHANGED handler must run', () => {
5353
expect(ran).toBeTruthy();
5454
});
55-
and(/^the event details must indicate "(.*)" was altered$/, (arg0) => {
55+
and(/^the event details must indicate "(.*)" was altered$/, () => {
5656
// not supported
5757
});
5858
});

libs/providers/flagd/src/lib/configuration.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FlagdProviderOptions, getConfig } from './configuration';
2-
import { DEFAULT_MAX_CACHE_SIZE, DEFAULT_MAX_EVENT_STREAM_RETRIES } from './constants';
2+
import { DEFAULT_MAX_CACHE_SIZE } from './constants';
33

44
describe('Configuration', () => {
55
const OLD_ENV = process.env;

libs/providers/flagd/src/lib/configuration.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { DEFAULT_MAX_CACHE_SIZE, DEFAULT_MAX_EVENT_STREAM_RETRIES } from './constants';
1+
import { DEFAULT_MAX_CACHE_SIZE } from './constants';
22

33
export type CacheOption = 'lru' | 'disabled';
44
export type ResolverType = 'rpc' | 'in-process';

0 commit comments

Comments
 (0)