Skip to content

Commit 8666ecd

Browse files
fix: GO Feature Flag web provider was using js-sdk import (#583)
Signed-off-by: Thomas Poignant <[email protected]>
1 parent 75c77f2 commit 8666ecd

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

libs/providers/go-feature-flag-web/src/lib/context-transfomer.spec.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1-
import {EvaluationContext} from '@openfeature/js-sdk';
21
import {GoFeatureFlagEvaluationContext} from './model';
32
import {transformContext} from './context-transformer';
4-
import {TargetingKeyMissingError} from "@openfeature/web-sdk";
3+
import {TargetingKeyMissingError, EvaluationContext} from "@openfeature/web-sdk";
54

65
describe('contextTransformer', () => {
76
it('should use the targetingKey as user key', () => {

libs/providers/go-feature-flag-web/src/lib/context-transformer.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
import {EvaluationContext} from '@openfeature/js-sdk';
21
import {GoFeatureFlagEvaluationContext} from './model';
3-
import {TargetingKeyMissingError} from "@openfeature/web-sdk";
2+
import {TargetingKeyMissingError, EvaluationContext} from "@openfeature/web-sdk";
43

54
/**
65
* transformContext takes the raw OpenFeature context returns a GoFeatureFlagEvaluationContext.

libs/providers/go-feature-flag-web/src/lib/go-feature-flag-web-provider.spec.ts

+9-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
import {GoFeatureFlagWebProvider} from './go-feature-flag-web-provider';
2-
import {EvaluationContext, OpenFeature, ProviderEvents, StandardResolutionReasons} from "@openfeature/web-sdk";
2+
import {
3+
EvaluationContext,
4+
OpenFeature,
5+
ProviderEvents,
6+
StandardResolutionReasons,
7+
ErrorCode,
8+
EvaluationDetails,
9+
JsonValue}
10+
from "@openfeature/web-sdk";
311
import WS from "jest-websocket-mock";
412
import TestLogger from "./test-logger";
5-
import {ErrorCode, EvaluationDetails, JsonValue} from "@openfeature/js-sdk";
613
import {GOFeatureFlagWebsocketResponse} from "./model";
714
import fetchMock from "fetch-mock-jest";
815

libs/providers/go-feature-flag-web/src/lib/model.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,4 @@
1-
import {
2-
ErrorCode,
3-
EvaluationContextValue,
4-
} from '@openfeature/js-sdk';
5-
import {FlagValue} from "@openfeature/web-sdk";
1+
import {FlagValue, ErrorCode, EvaluationContextValue} from "@openfeature/web-sdk";
62

73
/**
84
* GoFeatureFlagEvaluationContext is the representation of a user for GO Feature Flag

0 commit comments

Comments
 (0)