Skip to content

Commit d2b97dd

Browse files
authored
fix: module issues with types (#212)
1 parent 6ff5527 commit d2b97dd

File tree

6 files changed

+30
-4
lines changed

6 files changed

+30
-4
lines changed

assets/package.json

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"module": "commonjs"
3+
}

libs/hooks/open-telemetry/project.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
"entryFile": "libs/hooks/open-telemetry/src/index.ts",
1515
"tsConfig": "libs/hooks/open-telemetry/tsconfig.lib.json",
1616
"compiler": "tsc",
17-
"skipTypeField": true,
1817
"generateExportsField": true,
1918
"umdName": "OpenTelemetry",
2019
"external": [
@@ -25,6 +24,11 @@
2524
"esm"
2625
],
2726
"assets": [
27+
{
28+
"glob": "package.json",
29+
"input": "./assets",
30+
"output": "./src/"
31+
},
2832
{
2933
"glob": "LICENSE",
3034
"input": "./",

libs/providers/flagd-web/project.json

+5
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@
7070
"external": ["typescript"],
7171
"format": ["cjs", "esm"],
7272
"assets": [
73+
{
74+
"glob": "package.json",
75+
"input": "./assets",
76+
"output": "./src/"
77+
},
7378
{
7479
"glob": "LICENSE",
7580
"input": "./",

libs/providers/flagd/project.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,17 @@
6565
"entryFile": "libs/providers/flagd/src/index.ts",
6666
"tsConfig": "libs/providers/flagd/tsconfig.lib.json",
6767
"compiler": "tsc",
68-
"skipTypeField": true,
6968
"generateExportsField": true,
7069
"buildableProjectDepsInPackageJsonType": "dependencies",
7170
"umdName": "flagd",
7271
"external": ["typescript"],
7372
"format": ["cjs", "esm"],
7473
"assets": [
74+
{
75+
"glob": "package.json",
76+
"input": "./assets",
77+
"output": "./src/"
78+
},
7579
{
7680
"glob": "LICENSE",
7781
"input": "./",

libs/providers/go-feature-flag/project.json

+5-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
"entryFile": "libs/providers/go-feature-flag/src/index.ts",
4949
"tsConfig": "libs/providers/go-feature-flag/tsconfig.lib.json",
5050
"compiler": "tsc",
51-
"skipTypeField": true,
5251
"generateExportsField": true,
5352
"buildableProjectDepsInPackageJsonType": "dependencies",
5453
"umdName": "go-feature-flag",
@@ -60,6 +59,11 @@
6059
"esm"
6160
],
6261
"assets": [
62+
{
63+
"glob": "package.json",
64+
"input": "./assets",
65+
"output": "./src/"
66+
},
6367
{
6468
"glob": "LICENSE",
6569
"input": "./",

tools/generators/open-feature/index.ts

+7-1
Original file line numberDiff line numberDiff line change
@@ -129,12 +129,18 @@ function updateProject(tree: Tree, projectRoot: string, umdName: string) {
129129
tsConfig: `${projectRoot}/tsconfig.lib.json`,
130130
buildableProjectDepsInPackageJsonType: 'dependencies',
131131
compiler: 'tsc',
132-
skipTypeField: true,
133132
generateExportsField: true,
134133
umdName,
135134
external: ['typescript'],
136135
format: ['cjs', 'esm'],
137136
assets: [
137+
// Move a "commonjs" package.json to the types root (js is bundled).
138+
// This prevents us from having to add file extensions to all our imports in ESM contexts, which ESM requires.
139+
{
140+
glob: "package.json",
141+
input: "./assets",
142+
output: "./src/"
143+
},
138144
{
139145
glob: 'LICENSE',
140146
input: './',

0 commit comments

Comments
 (0)