fix(gofeatureflag): Error when receiving an empty string errorCode (#973)

Signed-off-by: Thomas Poignant <[email protected]>

Author: thomaspoignant

libs/providers/go-feature-flag/src/lib/controller/goff-api.ts

@@ -207,6 +207,9 @@ export class GoffApiController {
   }
 
   private convertErrorCode(errorCode: ErrorCode | undefined): ErrorCode | undefined {
+    if ((errorCode as string) === '') {
+      return undefined;
+    }
     if (errorCode === undefined) {
       return undefined;
     }

libs/providers/go-feature-flag/src/lib/go-feature-flag-provider.spec.ts

@@ -259,6 +259,41 @@ describe('GoFeatureFlagProvider', () => {
       };
       expect(res).toEqual(want);
     });
+
+    it('fix version 0.7.2', async () => {
+      const flagName = 'random-flag';
+      const targetingKey = 'user-key';
+      const dns = `${endpoint}v1/feature/${flagName}/eval`;
+
+      axiosMock.onPost(dns).reply(200, {
+        trackEvents: true,
+        variationType: 'True',
+        failed: false,
+        version: '',
+        reason: 'TARGETING_MATCH',
+        errorCode: '',
+        value: true,
+        cacheable: true,
+        metadata: {
+          description: 'this is a test',
+          pr_link: 'https://github.com/thomaspoignant/go-feature-flag/pull/916',
+        },
+      });
+
+      const res = await cli.getBooleanDetails(flagName, false, { targetingKey });
+      const want = {
+        flagKey: flagName,
+        reason: StandardResolutionReasons.TARGETING_MATCH,
+        value: true,
+        flagMetadata: {
+          description: 'this is a test',
+          pr_link: 'https://github.com/thomaspoignant/go-feature-flag/pull/916',
+        },
+        variant: 'True',
+      };
+      expect(res).toEqual(want);
+    });
+
     it('should resolve a valid boolean flag with SPLIT reason', async () => {
       const flagName = 'random-flag';
       const targetingKey = 'user-key';