chore(launchdarkly-provider): Review linter issues

Signed-off-by: mateo <[email protected]>

Author: Mateoc

libs/providers/launchdarkly-client/src/lib/launchdarkly-client-provider.spec.ts

@@ -8,7 +8,7 @@ import translateContext from './translate-context';
 const logger: TestLogger = new TestLogger();
 const testFlagKey = 'a-key';
 describe('LaunchDarklyClientProvider', () => {
-  let ldClient: LDClient;
+  let ldClient: Partial<LDClient>;
   let ldProvider: LaunchDarklyClientProvider
   let ofClient: Client;
 
@@ -17,8 +17,8 @@ describe('LaunchDarklyClientProvider', () => {
       variationDetail: jest.fn(),
       waitUntilReady: jest.fn().mockResolvedValue({}),
       getContext: jest.fn().mockReturnValue({}),
-    } as any;
-    ldProvider = new LaunchDarklyClientProvider(ldClient, { logger });
+    };
+    ldProvider = new LaunchDarklyClientProvider(ldClient as LDClient, { logger });
     OpenFeature.setProvider(ldProvider);
     ofClient = OpenFeature.getClient();
   })
@@ -70,8 +70,7 @@ describe('LaunchDarklyClientProvider', () => {
 
   describe('resolveBooleanEvaluation', () => {
     it('calls the client correctly for boolean variations', () => {
-      // @ts-ignore we don't care about the arguments
-      ldClient.variationDetail = jest.fn(async () => ({
+      ldClient.variationDetail = jest.fn(() => ({
         value: true,
         reason: {
           kind: 'OFF',

libs/providers/launchdarkly-client/src/lib/launchdarkly-client-provider.ts

@@ -63,7 +63,7 @@ export class LaunchDarklyClientProvider implements Provider {
     await this.client.identify(this.translateContext(newContext));
   }
 
-  resolveBooleanEvaluation(flagKey: string, defaultValue: boolean, context: EvaluationContext, logger: Logger): ResolutionDetails<boolean> {
+  resolveBooleanEvaluation(flagKey: string, defaultValue: boolean): ResolutionDetails<boolean> {
     const res = this.client.variationDetail(
       flagKey,
       defaultValue,
@@ -74,7 +74,7 @@ export class LaunchDarklyClientProvider implements Provider {
     return wrongTypeResult(defaultValue);
   }
 
-  resolveNumberEvaluation(flagKey: string, defaultValue: number, context: EvaluationContext, logger: Logger): ResolutionDetails<number> {
+  resolveNumberEvaluation(flagKey: string, defaultValue: number): ResolutionDetails<number> {
     const res = this.client.variationDetail(
       flagKey,
       defaultValue,
@@ -85,7 +85,7 @@ export class LaunchDarklyClientProvider implements Provider {
     return wrongTypeResult(defaultValue);
   }
 
-  resolveObjectEvaluation<T extends JsonValue>(flagKey: string, defaultValue: T, context: EvaluationContext, logger: Logger): ResolutionDetails<T> {
+  resolveObjectEvaluation<T extends JsonValue>(flagKey: string, defaultValue: T): ResolutionDetails<T> {
     const res = this.client.variationDetail(
       flagKey,
       defaultValue,
@@ -96,7 +96,7 @@ export class LaunchDarklyClientProvider implements Provider {
     return wrongTypeResult<T>(defaultValue);
   }
 
-  resolveStringEvaluation(flagKey: string, defaultValue: string, context: EvaluationContext, logger: Logger): ResolutionDetails<string> {
+  resolveStringEvaluation(flagKey: string, defaultValue: string): ResolutionDetails<string> {
     const res = this.client.variationDetail(
       flagKey,
       defaultValue,

libs/providers/launchdarkly-client/src/lib/test-logger.ts

@@ -19,19 +19,19 @@ import { LDLogger } from 'launchdarkly-js-client-sdk';
 export default class TestLogger implements LDLogger {
   public logs: string[] = [];
 
-  error(...args: any[]): void {
+  error(...args: unknown[]): void {
     this.logs.push(args.join(' '));
   }
 
-  warn(...args: any[]): void {
+  warn(...args: unknown[]): void {
     this.logs.push(args.join(' '));
   }
 
-  info(...args: any[]): void {
+  info(...args: unknown[]): void {
     this.logs.push(args.join(' '));
   }
 
-  debug(...args: any[]): void {
+  debug(...args: unknown[]): void {
     this.logs.push(args.join(' '));
   }
 

libs/providers/launchdarkly-client/src/lib/translate-context.ts

@@ -101,13 +101,12 @@ function translateContextCommon(
         privateAttributes: value as string[],
       };
     } else if (key in LDContextBuiltIns) {
-      // @ts-ignore previous if ensures key is an index of LDContextBuiltIns
-      if (typeof value === LDContextBuiltIns[key]) {
+      const typedKey = key as 'name'| 'anonymous';
+      if (typeof value === LDContextBuiltIns[typedKey]) {
         convertedContext[key] = value;
       } else {
         // If the type does not match, then discard.
-        // @ts-ignore previous if ensures key is an index of LDContextBuiltIns
-        logger.error(`The attribute '${key}' must be of type ${LDContextBuiltIns[key]}`);
+        logger.error(`The attribute '${key}' must be of type ${LDContextBuiltIns[typedKey]}`);
       }
     } else {
       convertAttributes(logger, key, value, convertedContext, [inCommon]);