Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add LRU TTL cache for GO Feature Flag Provider #411

Merged
merged 13 commits into from
Jun 16, 2023
Merged

feat: add LRU TTL cache for GO Feature Flag Provider #411

merged 13 commits into from
Jun 16, 2023

Conversation

thomaspoignant
Copy link
Member

@thomaspoignant thomaspoignant commented Jun 9, 2023 •
edited
Loading

This PR

  • adds a new LRU TTL Cache for the GO Feature Flag provider
  • add a call to the data collector to be sure that we have traces of feature flags evaluation that are using the cache.
  • missing tests sending events to the data collector.
  • This PR needs some tests on retrieving information from the cache.

Related Issues

Fixes thomaspoignant/go-feature-flag#659

Notes

@thomaspoignant
add LRU TTL Cache
42195a0 
Signed-off-by: Thomas Poignant <[email protected]>
@github-actions github-actions bot mentioned this pull request Jun 10, 2023
Closed
@thomaspoignant
Add comments
fb8e63d 
Signed-off-by: Thomas Poignant <[email protected]>
@beeme1mr
Copy link
Member

Hey Thomas, would the LRU Cache package work for you? It's already in the monorepo. If not, feel free to use Receptacle.

@thomaspoignant
Copy link
Member Author

Hey Thomas, would the LRU Cache package work for you? It's already in the monorepo. If not, feel free to use Receptacle.

I've looked at it and was not a big fan of the interface, but I will look at it again.

@thomaspoignant thomaspoignant marked this pull request as ready for review June 15, 2023 15:00
@thomaspoignant thomaspoignant requested a review from a team as a code owner June 15, 2023 15:00
@thomaspoignant
code style
f72a0e6 
Signed-off-by: Thomas Poignant <[email protected]>
@toddbaert toddbaert self-requested a review June 15, 2023 16:02
@thomaspoignant
Copy link
Member Author

@beeme1mr I've moved to LRU Cache package in the end.

@thomaspoignant thomaspoignant merged commit 1a76aec into open-feature:main Jun 16, 2023
@thomaspoignant thomaspoignant deleted the goff-cache branch June 16, 2023 09:47
@github-actions github-actions bot mentioned this pull request Jun 16, 2023
Merged
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr left review comments

@toddbaert toddbaert toddbaert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(feature) Implement open-feature provider cache for the Javascript provider
3 participants
@thomaspoignant @beeme1mr @toddbaert