Skip to content

fix: GOFF fix issues in hook #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix: GOFF fix issues in hook #585

merged 3 commits into from
Sep 18, 2023

Conversation

thomaspoignant
Copy link
Member

@thomaspoignant thomaspoignant commented Sep 17, 2023 •
edited
Loading

This PR

  • Missing check in the web provider
  • default field had a wrong value for errors.

@thomaspoignant
fix: GOFF missing check in hook
bd12bc5 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant requested a review from a team as a code owner September 17, 2023 18:13
@thomaspoignant
Fix default value for errors
6cc878c 
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant changed the title fix: GOFF missing check in hook fix: GOFF fix issues in hook Sep 18, 2023
@thomaspoignant thomaspoignant merged commit 6ca6463 into main Sep 18, 2023
@github-actions github-actions bot mentioned this pull request Sep 18, 2023
Merged
@toddbaert toddbaert deleted the goff-web-missing-options branch September 25, 2023 13:25
@github-actions github-actions bot mentioned this pull request Sep 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaspoignant @beeme1mr