-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Go feature flag provider #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Go feature flag provider #64
Conversation
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
|
@beeme1mr I struggle with the dependencies and where to store them in the mono repo. Should I place them on the top level instead? |
|
Hey @thomaspoignant, you should put dependencies at the root of the project. NX will automatically detect and include runtime dependencies as peer dependencies when it builds your package. |
|
I'll take a look at your branch and see if I can get the test passing. |
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
42c76a2 to
daea160
Compare
|
Hey @thomaspoignant, I was able to get it working. I tried to make my changes in granular commits so you could more easily follow my changes. There's a bit of NX magic involved but it's not too bad. Let me know if you have any questions. |
|
Thanks a lot @beeme1mr for your help 🙏 I saw your commits and I wonder if some things should not be part of the |
|
Hey @thomaspoignant, I'll try and review this today. I'll also create an issue to document how dependencies should be managed in NX. 15b2e8a should already be included in the generator. You can see the template here. I just tested it and it seem to be working as expected. Not sure what happened in your case. |
Signed-off-by: Michael Beemer <[email protected]>
|
18c11da was added to the generator after you ran it. Future providers and hooks will have this setup automatically. |
beeme1mr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for being the first official OpenFeature node js provider!
|
@thomaspoignant I updated the generator with https://github.com/open-feature/node-sdk-contrib/pull/63/files It adds some additional scripts to the package.json to enable releasing. I will add this to this PR if you dont mind to make sure all the release process works as expected. |
Signed-off-by: Todd Baert <[email protected]>
b1b88f9 to
accd42f
Compare
|
@thomaspoignant this is done. You can view my changes on this commit This stuff is now included in the generator, my commit just backports it to your changes. |
|
@toddbaert thanks a lot for your changes. I can have a look tomorrow when I will be in front of my computer |
This is a 1st version of the
go-feature-flagprovider.