Skip to content

chore: goff test env correction #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 6, 2023
Merged

chore: goff test env correction #672

merged 2 commits into from
Dec 6, 2023

Conversation

toddbaert
Copy link
Member

see title.

@toddbaert toddbaert requested a review from a team as a code owner December 6, 2023 19:17
@toddbaert toddbaert requested review from thomaspoignant, beeme1mr and Kavindu-Dodan and removed request for a team December 6, 2023 19:17
thomaspoignant
thomaspoignant approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing

@toddbaert
fixup: use general type
80641ce 
Signed-off-by: Todd Baert <[email protected]>
@toddbaert toddbaert merged commit 725baf3 into main Dec 6, 2023
@toddbaert toddbaert deleted the chore/fix-goff-test branch December 6, 2023 19:41
@github-actions github-actions bot mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@thomaspoignant thomaspoignant thomaspoignant approved these changes

@Kavindu-Dodan Kavindu-Dodan Awaiting requested review from Kavindu-Dodan

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toddbaert @beeme1mr @thomaspoignant