chore: loosen some test assertions, fix e2e matcher #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Jun 6, 2024
| build: | ||
| context: test-harness | ||
| dockerfile: flagd/Dockerfile | ||
| image: ghcr.io/open-feature/flagd-testbed:v0.5.4 |
toddbaert
commented
Jun 6, 2024
Comment on lines
+27
to
+28
| // the below has to match quotes strings ("str") and numbers (3) to test an error input | ||
| and(/^a context containing a key "(.*)", with value "?([^"]*)"?$/, (key: string, value: string) => { |
There was a problem hiding this comment.
This matcher probably should have never worked when we first added 3 as an error state, it looks like it was a bug eventually fixed in jest-gherkin. This regex matches "abc" and 3, which fixes the e2e test.
toddbaert
commented
Jun 6, 2024
Comment on lines
142
to
148
| expect(res).toEqual(expect.objectContaining({ | ||
| flagKey: testFlagKey, | ||
| flagMetadata: {}, | ||
| value: false, | ||
| reason: 'ERROR', | ||
| errorCode: 'TYPE_MISMATCH', | ||
| }); | ||
| })); |
There was a problem hiding this comment.
I've loosened a few brittle assertions with this PR, so that if new files are added/defaulted they don't break.
Signed-off-by: Todd Baert <[email protected]>
beeme1mr
approved these changes
Jun 6, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few issues in testing.