Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional map, where no point is selected, gives an error. #5038

Open
Tracked by #5032
vaszig opened this issue Jan 27, 2025 · 3 comments · May be fixed by open-formulieren/open-forms-sdk#791
Open
Tracked by #5032

Optional map, where no point is selected, gives an error. #5038

vaszig opened this issue Jan 27, 2025 · 3 comments · May be fixed by open-formulieren/open-forms-sdk#791
Assignees
@robinmolen
Labels
blocked owner: dimpact
Milestone
Release 3.1.0

Comments

@vaszig
Copy link
Contributor

vaszig commented Jan 27, 2025

No description provided.

@vaszig vaszig mentioned this issue Jan 27, 2025
Open
8 tasks
@vaszig vaszig added this to the Release 3.1.0 milestone Jan 27, 2025
@vaszig
Copy link
Contributor Author

vaszig commented Jan 27, 2025

The whole map component seems a bit unreliable.

@robinmolen robinmolen moved this from Todo to In Progress in Development Jan 30, 2025
@robinmolen
Copy link
Contributor

The map in 3.0.1 still used the old map interaction. So i think this error is old behavior.. (For as far is i can see, does the stable branch for 3.0.X only contain the new map tile layer (background) feature)

Do we want a backport for this issue? (i.e. setting the default value for the map component to []) Otherwise this issue will be resolved in 3.1.0, with the new map interactions

robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 30, 2025
@robinmolen
🐛 [open-formulieren/open-forms#5038] Missing map shapes in summary
8408f1e 
Because the geoJsonGeometry is available before the featureGroupRef is set, can the useEffect hook not draw the map shapes
@robinmolen robinmolen linked a pull request Jan 30, 2025 that will close this issue
Open
@robinmolen robinmolen linked a pull request Jan 30, 2025 that will close this issue
Missing map shapes in summary step open-formulieren/open-forms-sdk#791
Open
@joeribekker
Copy link
Contributor

Refinement: We'll backport this when its reported in the real world. It will be fixed in 3.1

robinmolen added a commit to open-formulieren/open-forms-sdk that referenced this issue Feb 20, 2025
@robinmolen
🐛 [open-formulieren/open-forms#5038] Missing map shapes in summary
7d1521a 
Restructured the drawing logic of the map component, ensuring that geoJsonGeometry and the featureGroupRef are available. This also further encapsulates the drawing logic from the more general map functionalities.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
blocked owner: dimpact
Projects
None yet
Milestone
Release 3.1.0
Development

Successfully merging a pull request may close this issue.

Missing map shapes in summary step open-formulieren/open-forms-sdk
3 participants
@joeribekker @vaszig @robinmolen