Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short term fix for matching Agent and Hub versions for the "all-in-one". #105

Open
TheMosquito opened this issue Mar 16, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@TheMosquito
Copy link
Member

How are users expected to get the correct version of the agent-install.sh script for an all-in-one Hub? I think this is not very well spelled out in https://github.com/open-horizon/devops/blob/master/mgmt-hub/README.md. Reading between the lines there, I think they are supposed to (at the exact same time as they get the deploy-mgmt-hub.sh for the all-in-one Management Hub installation) also get the corresponding agent-install.sh script, like this: curl -sSL https://github.com/open-horizon/anax/releases/latest/download/agent-install.sh. If they don’t pull it at exactly the same time, and save it for later, and then if “latest” moves, then things will break in subtle ways for them. I think we need to do better than this.
I'd like to suggest as a short term fix for this that the deploy-mgmt-hub.sh script should pull the agent-install.sh script and save it (and also tell the user where it is). That’s not a perfect solution for matching versions (because the user might have pulled the deploy-mgmt-hub.sh script earlier but then run it after latest has changed) but I think it’s better than not doing anything.
The real fix is to have a concrete mapping between Management Hub versions and corresponding Agent versions, which I believe is embodied in another issue elsewhere. So this is suggested as a short term fix.

@joewxboy joewxboy added enhancement New feature or request help wanted Extra attention is needed labels Mar 16, 2022
@joewxboy
Copy link
Member

@bmpotter Could I get your thoughts on this? The core issue is that we don't want the All-in-one script to drift too far from the agent-install script. This can typically happen when agents are installed in a later session from the Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants