Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: extend the functionality of the blessedSamples to accept GitHub repo url #611

Open
t-fine opened this issue Feb 25, 2025 · 2 comments
Assignees

Comments

@t-fine
Copy link
Collaborator

t-fine commented Feb 25, 2025

Is your feature request related to a problem? Please describe.

Extend the functionality of the blessedSamples method of publishing example services to the Exchange.

More details to come...

Describe the solution you'd like.

No response

Describe alternatives you've considered

No response

Additional context.

No response

@joewxboy
Copy link
Member

I don't know if we'll need to add sub-issues, or link to issues in other repos, but we discussed two potential changes:

  1. Allowing absolute, in addition to relative, paths within the blessedSamples file so that we can point to services in external repositories. This may introduce a potential attack vector if a person is able to point to a repo with an insecure or malicious service, so we'll want to think this through.
  2. Modifying the all-in-one installation script to have an optional override flag for the blessedSamples so that Adopters and Partners can create their own custom blessedSamples file that may live elsewhere. Again, we may want to consider how this functionality could be abused so that we don't introduce a vector for potential attacks.

@joewxboy
Copy link
Member

This issue is a required dependency for demo-in-a-box

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants