Skip to content

Commit 06c583d

Browse files
committed
fix(examplePairing): add more test coverage
1 parent ab57614 commit 06c583d

File tree

2 files changed

+16
-5
lines changed

2 files changed

+16
-5
lines changed

src/ExamplePairing/ExamplePairing.test.tsx

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,21 @@ import ReactDOM from "react-dom";
33
import ExamplePairing from "./ExamplePairing";
44
import examples from "@open-rpc/examples";
55
import refParser from "json-schema-ref-parser";
6+
import { OpenrpcDocument } from "@open-rpc/meta-schema";
7+
8+
it("renders handles no method", async () => {
9+
const div = document.createElement("div");
10+
ReactDOM.render(<ExamplePairing method={undefined} examplePosition={0}/>, div);
11+
expect(div.innerHTML).toBe("");
12+
ReactDOM.unmountComponentAtNode(div);
13+
});
14+
15+
it("renders handles no method examples", async () => {
16+
const div = document.createElement("div");
17+
ReactDOM.render(<ExamplePairing method={{} as any} examplePosition={0} />, div);
18+
expect(div.innerHTML).toBe("");
19+
ReactDOM.unmountComponentAtNode(div);
20+
});
621

722
it("renders handles no examplePosition", async () => {
823
const div = document.createElement("div");
@@ -11,7 +26,6 @@ it("renders handles no examplePosition", async () => {
1126
expect(div.innerHTML).toBe("");
1227
ReactDOM.unmountComponentAtNode(div);
1328
});
14-
import { OpenrpcDocument } from "@open-rpc/meta-schema";
1529

1630
it("renders examples", async () => {
1731
const div = document.createElement("div");

src/ExamplePairing/ExamplePairing.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,7 @@ class ExamplePairing extends Component<IProps, {}> {
3333
if (!example || _.isEmpty(example)) {
3434
return null;
3535
}
36-
if (!method) {
37-
return;
38-
}
39-
const paramStructure: TParamStructure = method.paramStructure || "either";
36+
const paramStructure: TParamStructure = method?.paramStructure || "either";
4037
const params = paramStructure === "by-name"
4138
? (example.params as ExampleObject[]).reduce(((memo, p) => {
4239
memo[p.name] = p.value;

0 commit comments

Comments
 (0)